Opened 8 months ago

Closed 8 months ago

#26480 closed enhancement (fixed)

clean graph_latex.py

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: e62a793 (Commits) Commit: e62a79356f928cc795938681e4af543877865ba4
Dependencies: Stopgaps:

Description

clean graph_latex.py.

Change History (5)

comment:1 Changed 8 months ago by dcoudert

  • Branch set to public/26480_graph_latex
  • Cc tscrim added
  • Commit set to e62a79356f928cc795938681e4af543877865ba4
  • Keywords py3 graph added
  • Status changed from new to needs_review

In method tkz_picture, I don't understand why building a (big) list of strings before concatenating int to a string (and returning it). Any idea ?


New commits:

e62a793trac #26480: clean graph_latex.py

comment:2 Changed 8 months ago by chapoton

It is usually faster to concatenate a list of strings once at the end, than to add them little by little.

comment:3 Changed 8 months ago by dcoudert

  • Milestone changed from sage-8.4 to sage-8.5

comment:4 Changed 8 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be

comment:5 Changed 8 months ago by vbraun

  • Branch changed from public/26480_graph_latex to e62a79356f928cc795938681e4af543877865ba4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.