#26479 closed defect (fixed)
padic printer does not support latex names
Reported by:  caruso  Owned by:  

Priority:  major  Milestone:  sage8.5 
Component:  padics  Keywords:  
Cc:  roed  Merged in:  
Authors:  Xavier Caruso  Reviewers:  David Roe, Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  fb3bbaa (Commits)  Commit:  fb3bbaa1e333112e4ee34bec5712b45a845841ac 
Dependencies:  Stopgaps: 
Description
sage: K.<pi> = Qp(2).extension(x^3  2) sage: latex(pi) 'pi + O(pi^61)'
Change History (11)
comment:1 Changed 9 months ago by
 Branch set to u/caruso/padic_printer_latex
 Commit set to 8b1816472114ac456a509e11cdd974274041fe4b
 Status changed from new to needs_review
comment:2 followup: ↓ 4 Changed 9 months ago by
comment:3 Changed 9 months ago by
 Commit changed from 8b1816472114ac456a509e11cdd974274041fe4b to 008d7fc45c055246740f55d524fca084f19914e0
comment:4 in reply to: ↑ 2 Changed 9 months ago by
Replying to chapoton:
Please undo all changes from
\ZZ
to\Bold{Z}
in the documentation.For the uniformity of sage documentation, it is better to always use
\ZZ
.
Ah OK. It's a kind of trap because we cannot use \ZZ
in the notebook for instance.
Anyway, I made the changes and also replaced \mathbb{Z}
by \ZZ
, etc. Please tell me if it's not appropriate.
comment:5 Changed 9 months ago by
I think we also have \GF
for finite fields. But all these cosmetic changes should really be done IMHO in another ticket, because they currently hide the important changes in this ticket, which get lost in the middle of all the changes made.
comment:6 Changed 9 months ago by
 Commit changed from 008d7fc45c055246740f55d524fca084f19914e0 to 9e85f914c9bbfbb45c0123b241512ffba24bb757
comment:7 Changed 9 months ago by
OK, if you insist, I split this ticket into two parts.
comment:8 Changed 9 months ago by
 Commit changed from 9e85f914c9bbfbb45c0123b241512ffba24bb757 to fb3bbaa1e333112e4ee34bec5712b45a845841ac
Branch pushed to git repo; I updated commit sha1. New commits:
fb3bbaa  Fix doctests

comment:9 Changed 9 months ago by
 Reviewers set to David Roe, Frédéric Chapoton
 Status changed from needs_review to positive_review
Looks good! I ran long tests and they pass.
comment:10 Changed 9 months ago by
 Branch changed from u/caruso/padic_printer_latex to fb3bbaa1e333112e4ee34bec5712b45a845841ac
 Resolution set to fixed
 Status changed from positive_review to closed
comment:11 Changed 9 months ago by
 Milestone changed from sage8.4 to sage8.5
This should be retargeted for 8.5.
Please undo all changes from
\ZZ
to\Bold{Z}
in the documentation.For the uniformity of sage documentation, it is better to always use
\ZZ
.