Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#26477 closed enhancement (fixed)

remove deprecated stuff in polynomial_element

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: commutative algebra Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 046a9c4 (Commits, GitHub, GitLab) Commit: 046a9c4eb4c0fb3da030571a3a1d9ed3d6105140
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

plus small-scale partial pep8 cleanup

after #17518 and #18420

Change History (7)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26477
  • Commit set to 046a9c4eb4c0fb3da030571a3a1d9ed3d6105140
  • Status changed from new to needs_review

New commits:

046a9c4remove deprecated stuff in polynomial_element.pyx

comment:2 Changed 3 years ago by chapoton

  • Description modified (diff)

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Should we have an alias coeffs = coefficients? It seems like from #17518 that this was the intended effect. Or is this already there?

comment:4 Changed 3 years ago by chapoton

One message there says

 * removing/deprecating the `coeff` and `coeffs` aliases

comment:5 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

I am not sure I agree with that, but okay, I don't have a big stake in this.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26477 to 046a9c4eb4c0fb3da030571a3a1d9ed3d6105140
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 3 years ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.