Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#26476 closed enhancement (fixed)

refine the category of Symmetric groups

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1040965 (Commits) Commit: 10409656124a6fc3614d4d5a64f9d523946686ca
Dependencies: Stopgaps:

Description

as they are irreducible as reflection groups

Change History (8)

comment:1 Changed 14 months ago by chapoton

  • Branch set to u/chapoton/26476
  • Commit set to bdf4cfe3e167c49d005adafe72feea5850db1657
  • Status changed from new to needs_review

New commits:

bdf4cferefine the category of Symmetric Groups (they are irreducible refl. groups)

comment:2 Changed 14 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

LGTM. You can switch to positive when the patchbot comes back green.

comment:3 Changed 14 months ago by git

  • Commit changed from bdf4cfe3e167c49d005adafe72feea5850db1657 to 10409656124a6fc3614d4d5a64f9d523946686ca

Branch pushed to git repo; I updated commit sha1. New commits:

1040965adding a doctest for noncrossing partitions

comment:4 Changed 14 months ago by chapoton

oh, sorry, you were too quick. I just added a doctest on noncrossing partitions, that was my motivation.

comment:5 Changed 14 months ago by chapoton

ok, patchbot is green. Do you agree with the added doctest ?

comment:6 Changed 14 months ago by tscrim

  • Status changed from needs_review to positive_review

Yep, LGTM.

comment:7 Changed 14 months ago by vbraun

  • Branch changed from u/chapoton/26476 to 10409656124a6fc3614d4d5a64f9d523946686ca
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 14 months ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.