Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#26475 closed defect (fixed)

py3: make all tests in manifolds passed

Reported by: egourgoulhon Owned by:
Priority: major Milestone: sage-8.5
Component: geometry Keywords: python3
Cc: chapoton, tscrim Merged in:
Authors: Eric Gourgoulhon Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 46bae3b (Commits) Commit:
Dependencies: Stopgaps:

Description

This fixes all doctest errors with python3 in src/sage/manifolds.

Change History (9)

comment:1 Changed 4 months ago by egourgoulhon

  • Branch set to public/manifolds/py3_fix
  • Cc chapoton tscrim added
  • Commit set to 701a9aea096b8cb02961d64cd673ecad899448aa
  • Component changed from python3 to geometry
  • Keywords python3 added
  • Status changed from new to needs_review

New commits:

​701a9aeMake all doctests in manifolds passed with python3

comment:2 follow-up: Changed 4 months ago by chapoton

looks good. Would you like to use the opportunity to fix the few pyflakes warnings in the modified files ?

comment:3 in reply to: ↑ 2 ; follow-up: Changed 4 months ago by egourgoulhon

Replying to chapoton:

looks good. Would you like to use the opportunity to fix the few pyflakes warnings in the modified files ?

Sure! I'll do it asap.

comment:4 Changed 4 months ago by git

  • Commit changed from 701a9aea096b8cb02961d64cd673ecad899448aa to 46bae3b27ee10a2686af8985a4c245606924c5c4

Branch pushed to git repo; I updated commit sha1. New commits:

​a03e3ebMerge branch 'public/manifolds/py3_fix' of git://trac.sagemath.org/sage into Sage 8.4.rc1.
​46bae3bCorrect pyflakes error in manifolds

comment:5 in reply to: ↑ 3 Changed 4 months ago by egourgoulhon

Replying to egourgoulhon:

Replying to chapoton:

looks good. Would you like to use the opportunity to fix the few pyflakes warnings in the modified files ?

Sure! I'll do it asap.

Done!

comment:6 Changed 4 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good to go

comment:7 Changed 4 months ago by vbraun

  • Branch changed from public/manifolds/py3_fix to 46bae3b27ee10a2686af8985a4c245606924c5c4
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 4 months ago by chapoton

  • Commit 46bae3b27ee10a2686af8985a4c245606924c5c4 deleted

sequel in #26569 (sigh..)

comment:9 Changed 4 months ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.