Opened 16 months ago

Last modified 15 months ago

#26468 closed enhancement

Py3: Some fixes in combinat/finite_state_machine.py — at Version 4

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Vincent Klein Reviewers:
Report Upstream: N/A Work issues:
Branch: u/vklein/26468 (Commits) Commit: 18e06f0e974dffd67f907369889d140ad315ebab
Dependencies: Stopgaps:

Description (last modified by vklein)

Before:

30 items had failures:
  23 of  87 in sage.combinat.finite_state_machine
   7 of  21 in sage.combinat.finite_state_machine.?
   4 of   6 in sage.combinat.finite_state_machine.?.?
   3 of   5 in sage.combinat.finite_state_machine.?.Current
   6 of  24 in sage.combinat.finite_state_machine.?.__next__
   7 of  11 in sage.combinat.finite_state_machine.?._push_branch_
   5 of   7 in sage.combinat.finite_state_machine.?._push_branches_
   5 of   7 in sage.combinat.finite_state_machine.?.preview_word
   9 of  10 in sage.combinat.finite_state_machine.?.result
  16 of  36 in sage.combinat.finite_state_machine.Automaton.determinisation
   3 of   6 in sage.combinat.finite_state_machine.Automaton.language
   2 of  12 in sage.combinat.finite_state_machine.Automaton.minimization
   8 of  16 in sage.combinat.finite_state_machine.Automaton.process
   4 of  14 in sage.combinat.finite_state_machine.Automaton.with_output
  16 of  81 in sage.combinat.finite_state_machine.FiniteStateMachine
  21 of 266 in sage.combinat.finite_state_machine.FiniteStateMachine.?
  10 of  68 in sage.combinat.finite_state_machine.FiniteStateMachine.__call__
   4 of  11 in sage.combinat.finite_state_machine.FiniteStateMachine._iter_process_simple_
   2 of   3 in sage.combinat.finite_state_machine.FiniteStateMachine._matrix_
   1 of  20 in sage.combinat.finite_state_machine.FiniteStateMachine.add_transition
   2 of  86 in sage.combinat.finite_state_machine.FiniteStateMachine.asymptotic_moments
   4 of   7 in sage.combinat.finite_state_machine.FiniteStateMachine.coaccessible_components
   1 of  37 in sage.combinat.finite_state_machine.FiniteStateMachine.disjoint_union
   2 of  21 in sage.combinat.finite_state_machine.FiniteStateMachine.kleene_star
  14 of  47 in sage.combinat.finite_state_machine.FiniteStateMachine.process
   2 of  32 in sage.combinat.finite_state_machine.Transducer.cartesian_product
   5 of  41 in sage.combinat.finite_state_machine.Transducer.process
   4 of   6 in sage.combinat.finite_state_machine._FSMProcessIteratorAll_
   1 of  11 in sage.combinat.finite_state_machine._FSMTapeCache_.finished
   1 of   4 in sage.combinat.finite_state_machine.setup_latex_preamble
    [2100 tests, 192 failures, 3.66 s]
----------------------------------------------------------------------
sage -t --long src/sage/combinat/finite_state_machine.py  # 192 doctests failed
----------------------------------------------------------------------

After:

17 items had failures:
   1 of  87 in sage.combinat.finite_state_machine
   9 of  36 in sage.combinat.finite_state_machine.Automaton.determinisation
   2 of  12 in sage.combinat.finite_state_machine.Automaton.minimization
   1 of  16 in sage.combinat.finite_state_machine.Automaton.process
   2 of  81 in sage.combinat.finite_state_machine.FiniteStateMachine
   3 of 266 in sage.combinat.finite_state_machine.FiniteStateMachine.?
   3 of  11 in sage.combinat.finite_state_machine.FiniteStateMachine._iter_process_simple_
   1 of   3 in sage.combinat.finite_state_machine.FiniteStateMachine._matrix_
   1 of  20 in sage.combinat.finite_state_machine.FiniteStateMachine.add_transition
   2 of  86 in sage.combinat.finite_state_machine.FiniteStateMachine.asymptotic_moments
   4 of   7 in sage.combinat.finite_state_machine.FiniteStateMachine.coaccessible_components
   1 of  37 in sage.combinat.finite_state_machine.FiniteStateMachine.disjoint_union
   1 of  21 in sage.combinat.finite_state_machine.FiniteStateMachine.kleene_star
   9 of  47 in sage.combinat.finite_state_machine.FiniteStateMachine.process
   2 of  32 in sage.combinat.finite_state_machine.Transducer.cartesian_product
   1 of  11 in sage.combinat.finite_state_machine._FSMTapeCache_.finished
   1 of   4 in sage.combinat.finite_state_machine.setup_latex_preamble
    [2100 tests, 44 failures, 3.69 s]
----------------------------------------------------------------------
sage -t --long src/sage/combinat/finite_state_machine.py  # 44 doctests failed
----------------------------------------------------------------------
Total time for all tests: 4.0 seconds
    cpu time: 4.1 seconds
    cumulative wall time: 3.7 seconds

Change History (4)

comment:1 Changed 16 months ago by vklein

  • Branch set to u/vklein/26468

comment:2 Changed 16 months ago by git

  • Commit set to 18e06f0e974dffd67f907369889d140ad315ebab

Branch pushed to git repo; I updated commit sha1. New commits:

18e06f0Trac #26468: Py3 fix few finite_state_machine errors

comment:3 Changed 16 months ago by vklein

  • Description modified (diff)

comment:4 Changed 16 months ago by vklein

  • Description modified (diff)
Note: See TracTickets for help on using tickets.