Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#26468 closed enhancement (fixed)

Py3: Some fixes in combinat/finite_state_machine.py

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Vincent Klein Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 29bc1be (Commits) Commit: 29bc1bee2732174cbe0177651a906f363838e301
Dependencies: Stopgaps:

Change History (13)

comment:1 Changed 13 months ago by vklein

  • Branch set to u/vklein/26468

comment:2 Changed 13 months ago by git

  • Commit set to 18e06f0e974dffd67f907369889d140ad315ebab

Branch pushed to git repo; I updated commit sha1. New commits:

18e06f0Trac #26468: Py3 fix few finite_state_machine errors

comment:3 Changed 13 months ago by vklein

  • Description modified (diff)

comment:4 Changed 13 months ago by vklein

  • Description modified (diff)

comment:5 Changed 13 months ago by chapoton

see also #26147

comment:6 Changed 13 months ago by chapoton

@vklein, may I suggest that you could set-up your own patchbot to run on your tickets ?

This is easy, and just mean, inside a virtual machine, git clone the patchbot sources and run the patchbot according to the explanations in https://wiki.sagemath.org/patchbot

comment:7 Changed 13 months ago by vklein

I will look at it. Thanks.

comment:8 Changed 13 months ago by git

  • Commit changed from 18e06f0e974dffd67f907369889d140ad315ebab to 29bc1bee2732174cbe0177651a906f363838e301

Branch pushed to git repo; I updated commit sha1. New commits:

29bc1beTrac #26468: Reverse modification already done by #26147

comment:9 Changed 13 months ago by vklein

  • Description modified (diff)
  • Status changed from new to needs_review

comment:10 Changed 13 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be

comment:11 Changed 13 months ago by vklein

Thanks !

comment:12 Changed 13 months ago by vbraun

  • Branch changed from u/vklein/26468 to 29bc1bee2732174cbe0177651a906f363838e301
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:13 Changed 13 months ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.