Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#26466 closed enhancement (fixed)

Py3: Fix DeprecationWarning: generator X raised StopIteration

Reported by: vklein Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords: thursdaysbdx
Cc: Merged in:
Authors: Vincent Klein Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 9da555b (Commits) Commit: 9da555b18f92ecc5188432624d5eec2249e5c784
Dependencies: Stopgaps:

Description

Following #26458 this ticket aim at fixing the remaining cases of DeprecationWarning: generator X raised StopIteration in sage.

Change History (11)

comment:1 Changed 14 months ago by vklein

  • Branch set to u/vklein/26466

comment:2 Changed 14 months ago by vklein

  • Commit set to 9da555b18f92ecc5188432624d5eec2249e5c784
  • Keywords #thursdaysbdx added

New commits:

9da555bTrac #26466: Fix some Deprecation warning for generator ...

comment:3 Changed 14 months ago by vklein

  • Keywords thursdaysbdx added; #thursdaysbdx removed

comment:4 Changed 14 months ago by vklein

  • Authors set to Vincent Klein

comment:5 Changed 14 months ago by chapoton

is this ready for review ?

comment:6 Changed 14 months ago by vklein

Not really i still have one more case i try to solve.

comment:7 Changed 14 months ago by vklein

That being said you can make review/comments for what it's done by 9da555b commit.

Last edited 14 months ago by vklein (previous) (diff)

comment:8 Changed 14 months ago by vklein

  • Status changed from new to needs_review

Well i'm still not sure what the right thing to do for "generator" '_FSMTapeCache_.preview_word.<locals>.<genexpr>' it seems to me that raise StopIteration is misused here in the first place as preview_word is not a proper generator nor an iterator. I need a better understanding of _FSMTapeCache_ before fixing this.

The preview_word case will not be fixed in this ticket.

Last edited 14 months ago by vklein (previous) (diff)

comment:9 Changed 14 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, then good to go.

comment:10 Changed 14 months ago by vbraun

  • Branch changed from u/vklein/26466 to 9da555b18f92ecc5188432624d5eec2249e5c784
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 14 months ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.