#26448 closed enhancement (fixed)
clean hyperbolicity.pyx
Reported by:  dcoudert  Owned by:  

Priority:  major  Milestone:  sage8.5 
Component:  graph theory  Keywords:  py3, graph 
Cc:  tscrim, chapoton  Merged in:  
Authors:  David Coudert  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  2366c76 (Commits)  Commit:  2366c76b7e8b37c172b8cd32fb1157c5d0d1625c 
Dependencies:  Stopgaps: 
Description
Various PEP8 corrections and fix sorted
statements.
Change History (6)
comment:1 Changed 2 years ago by
 Branch set to public/26448_hyperbolicity_pyx
 Cc tscrim chapoton added
 Commit set to be463bd62a1d7d1f7b835fbb729a3bca7e3acfc8
 Status changed from new to needs_review
comment:2 Changed 2 years ago by
 Reviewers set to Travis Scrimshaw
LGTM modulo
@@ 361,10 +361,18 @@ cdef tuple hyperbolicity_basic_algorithm(int N, def _greedy_dominating_set(H, verbose=False): r""" Returns a greedy approximation of a dominating set + + EXAMPLES: + + sage: from sage.graphs.hyperbolicity import _greedy_dominating_set + sage: G = graphs.PetersenGraph() + sage: _greedy_dominating_set(G) + [0, 2, 6] """
should be EXAMPLES::
 if len(certificate) == 0: + if not len(certificate):
could be simply if not certificate
and
raise ValueError("algorithm '%s' not yet implemented. Please contribute" %(algorithm)) +raise ValueError("algorithm '%s' not yet implemented, please contribute" %(algorithm))
for sentence syntax.
Once changed, you can set a positive review on my behalf.
comment:3 Changed 2 years ago by
 Commit changed from be463bd62a1d7d1f7b835fbb729a3bca7e3acfc8 to 2366c76b7e8b37c172b8cd32fb1157c5d0d1625c
Branch pushed to git repo; I updated commit sha1. New commits:
2366c76  trac #26448: review comments

comment:5 Changed 2 years ago by
 Branch changed from public/26448_hyperbolicity_pyx to 2366c76b7e8b37c172b8cd32fb1157c5d0d1625c
 Resolution set to fixed
 Status changed from positive_review to closed
comment:6 Changed 2 years ago by
 Milestone changed from sage8.4 to sage8.5
This should be retargeted for 8.5.
Note: See
TracTickets for help on using
tickets.
There a decision to take: method
hyperbolicity
sorts the vertices of the output. As this method is not yet exposed inGraph
and that the sorted list of vertices has only 4 vertices, we can just remove this sorting. Do you agree ?New commits:
trac #26448: cleaning