Opened 2 years ago

Closed 2 years ago

#26446 closed enhancement (fixed)

clean lovasz_theta, isgci, independent_set

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f697547 (Commits) Commit: f697547c92451dac7f30a88cd3eb644a8ad6a9ad
Dependencies: Stopgaps:

Description (last modified by dcoudert)

Clean files lovasz_theta.py, isgci.py and independent_set. Alignments, PEP8, etc.

Change History (12)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to public/26446_cleaning
  • Commit set to 36081b6fdd12a24c84c7afe1cb74f3c30a9db7be
  • Status changed from new to needs_review

New commits:

​9d62c0dlovasz_theta.py and linearextensions.py
​f27ec62isgci
​36081b6idependent_set.pyx

comment:2 Changed 2 years ago by mantepse

note that linearextensions.py is essentially removed in #25864.

comment:3 Changed 2 years ago by git

  • Commit changed from 36081b6fdd12a24c84c7afe1cb74f3c30a9db7be to cdc9ccd85f11df3fef278ff3d75e846ce5e790a7

Branch pushed to git repo; I updated commit sha1. New commits:

​cdc9ccdtrac #26446: revert changes in linearextensions.py

comment:4 Changed 2 years ago by git

  • Commit changed from cdc9ccd85f11df3fef278ff3d75e846ce5e790a7 to 136f29ce759b34535eac791b094e3fa1a8f52151

Branch pushed to git repo; I updated commit sha1. New commits:

​136f29ctrac #26446: revert changes in linearextensions.py (2)

comment:5 Changed 2 years ago by dcoudert

  • Description modified (diff)
  • Summary changed from clean lovasz_theta, linearextensions, isgci, independent_set to clean lovasz_theta, isgci, independent_set

Thanks for the information. I have reverted the changes in this file to avoid conflicts.

comment:6 Changed 2 years ago by mantepse

That's very kind! Thank you!

comment:7 Changed 2 years ago by dcoudert

  • Milestone changed from sage-8.4 to sage-8.5

comment:8 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

This is one of those (annoying) long error messages with multiple sentences that needs leading capitalization and period: 

-            raise ValueError("The given class id does not exist in the ISGCI database. Is the db too old ? You can update it with graph_classes.update_db().")
+            raise ValueError("the given class id does not exist in the ISGCI database. Is the db too old ? You can update it with graph_classes.update_db()")

However, this one should not have a period: 

raise ValueError(str(I) + " is not a vertex of the graph.")

comment:9 Changed 2 years ago by git

  • Commit changed from 136f29ce759b34535eac791b094e3fa1a8f52151 to f697547c92451dac7f30a88cd3eb644a8ad6a9ad

Branch pushed to git repo; I updated commit sha1. New commits:

​fa4a15ftrac #26446: Merged with 8.5.beta0
​f697547trac #26446: fix error messages

comment:10 Changed 2 years ago by dcoudert

Corrected.

comment:11 Changed 2 years ago by tscrim

  • Status changed from needs_review to positive_review

Thanks.

comment:12 Changed 2 years ago by vbraun

  • Branch changed from public/26446_cleaning to f697547c92451dac7f30a88cd3eb644a8ad6a9ad
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.