Opened 13 months ago

Closed 12 months ago

Last modified 12 months ago

#26444 closed enhancement (fixed)

Use maximal cliques iterator for line graph

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords:
Cc: tscrim Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: dc7eb67 (Commits) Commit: dc7eb673aef14638c7abc8e720f0bd43b8b3c2be
Dependencies: Stopgaps:

Description

Use a maximal cliques iterator in method root_graph, and use root_graph instead of line graph forbidden subgraph search in method is_line_graph. This was a long standing request to speed up the method.

Change History (8)

comment:1 Changed 13 months ago by dcoudert

  • Branch set to public/26444_line_graph
  • Cc tscrim added
  • Commit set to 9817e86d1323d9674b1533d25b41ae917c4878bf
  • Status changed from new to needs_review

comment:2 Changed 13 months ago by git

  • Commit changed from 9817e86d1323d9674b1533d25b41ae917c4878bf to 1ee9562618d955ea3109248a422ab644c7ef5d30

Branch pushed to git repo; I updated commit sha1. New commits:

1ee9562trac #26444: revert the use of iteritems

comment:3 Changed 13 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Two little nitpicks: not x in C -> x not in C and you don't need the \ in add_edges because of the parentheses. Once fixed, you can set a positive review on my behalf.

comment:4 Changed 13 months ago by tscrim

  • Status changed from positive_review to needs_review

comment:5 Changed 13 months ago by git

  • Commit changed from 1ee9562618d955ea3109248a422ab644c7ef5d30 to dc7eb673aef14638c7abc8e720f0bd43b8b3c2be

Branch pushed to git repo; I updated commit sha1. New commits:

dc7eb67trac #26444: review comments

comment:6 Changed 13 months ago by dcoudert

  • Status changed from needs_review to positive_review

Thank you.

comment:7 Changed 12 months ago by vbraun

  • Branch changed from public/26444_line_graph to dc7eb673aef14638c7abc8e720f0bd43b8b3c2be
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 12 months ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.