Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#26429 closed enhancement (fixed)

py3: fix some doctests in game_theory

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: bb0122e (Commits) Commit: bb0122e37b99625551ef91356b7c478416512c94
Dependencies: Stopgaps:

Description


Change History (9)

comment:1 Changed 8 months ago by chapoton

  • Branch set to u/chapoton/26429
  • Commit set to b104467620be8382e6a7583b576d45d5f8af2e49
  • Status changed from new to needs_review

New commits:

b104467py3: fixing some doctests in game_theory/

comment:2 Changed 8 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 7 months ago by vbraun

  • Status changed from positive_review to needs_work
**********************************************************************
File "src/sage/game_theory/normal_form_game.py", line 437, in sage.game_theory.normal_form_game
Failed example:
    g  # optional - gambit
Expected:
    Normal Form Game with the following utilities: {(0, 1): [2.0, 10.0], (1, 0): [10.0, 2.0], (0, 0): [8.0, 8.0], (1, 1): [5.0, 5.0]}
Got:
    Normal Form Game with the following utilities: {(0, 0): [8.0, 8.0],
     (0, 1): [2.0, 10.0],
     (1, 0): [10.0, 2.0],
     (1, 1): [5.0, 5.0]}
**********************************************************************
File "src/sage/game_theory/normal_form_game.py", line 719, in sage.game_theory.normal_form_game.NormalFormGame.__init__
Failed example:
    g  # optional - gambit
Expected:
    Normal Form Game with the following utilities: {(0, 1): [2.0, 11.0], (1, 0): [10.0, 7.0], (0, 0): [5.0, 8.0], (1, 1): [5.0, 5.0]}
Got:
    Normal Form Game with the following utilities: {(0, 0): [5.0, 8.0],
     (0, 1): [2.0, 11.0],
     (1, 0): [10.0, 7.0],
     (1, 1): [5.0, 5.0]}
**********************************************************************
File "src/sage/game_theory/normal_form_game.py", line 979, in sage.game_theory.normal_form_game.NormalFormGame._gambit_game
Failed example:
    g  # optional - gambit
Expected:
    Normal Form Game with the following utilities:
     {(0, 1): [2.0, 10.0], (1, 0): [10.0, 2.0],
      (0, 0): [8.0, 8.0], (1, 1): [5.0, 5.0]}
Got:
    Normal Form Game with the following utilities: {(0, 0): [8.0, 8.0],
     (0, 1): [2.0, 10.0],
     (1, 0): [10.0, 2.0],
     (1, 1): [5.0, 5.0]}
**********************************************************************
3 items had failures:
   1 of 151 in sage.game_theory.normal_form_game
   1 of  51 in sage.game_theory.normal_form_game.NormalFormGame.__init__
   1 of  14 in sage.game_theory.normal_form_game.NormalFormGame._gambit_game
    [665 tests, 3 failures, 2.16 s]
----------------------------------------------------------------------
sage -t src/sage/game_theory/normal_form_game.py  # 3 doctests failed
----------------------------------------------------------------------

comment:4 Changed 7 months ago by git

  • Commit changed from b104467620be8382e6a7583b576d45d5f8af2e49 to bb0122e37b99625551ef91356b7c478416512c94

Branch pushed to git repo; I updated commit sha1. New commits:

adf03e9Merge branch 'u/chapoton/26429' in 8.4
bb0122etrac 26429 fixing gambit optional doctests

comment:5 Changed 7 months ago by chapoton

  • Status changed from needs_work to needs_review

fixed the gambit optional doctests

comment:6 Changed 7 months ago by chapoton

bot is morally green, please review

comment:7 Changed 7 months ago by tscrim

  • Status changed from needs_review to positive_review

comment:8 Changed 7 months ago by vbraun

  • Branch changed from u/chapoton/26429 to bb0122e37b99625551ef91356b7c478416512c94
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 7 months ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.