Opened 21 months ago
Closed 20 months ago
#26420 closed enhancement (fixed)
More flexible constructor of GroupHomomorphisms
Reported by:  sbrandhorst  Owned by:  

Priority:  major  Milestone:  sage8.5 
Component:  group theory  Keywords:  
Cc:  tscrim, soehms  Merged in:  
Authors:  Simon Brandhorst  Reviewers:  Sebastian Oehms 
Report Upstream:  N/A  Work issues:  
Branch:  21cb664 (Commits)  Commit:  21cb66449cd424f94d15bd695fa986a0ce40c30c 
Dependencies:  Stopgaps: 
Description
Right now a group homomorphism is defined on images of the generator of the group. In gap there are many more ways to define a group homomorphism. With this ticket a group homomorphism in sage can be created from the one in gap.
Change History (9)
comment:1 Changed 21 months ago by
 Cc soehms added
comment:2 Changed 21 months ago by
 Branch set to u/sbrandhorst/more_flexible_constructor_of__grouphomomorphisms
comment:3 Changed 21 months ago by
 Commit set to 08a07359c7141f4b849a554c114e59e0463b74bb
comment:4 Changed 21 months ago by
 Commit changed from 08a07359c7141f4b849a554c114e59e0463b74bb to b2d9622e20c607355e215d8748d4dba3c88ba7a1
Branch pushed to git repo; I updated commit sha1. New commits:
b2d9622  docs

comment:5 Changed 21 months ago by
 Status changed from new to needs_review
comment:6 Changed 20 months ago by
 Reviewers set to Sebastian Oehms
Two lines of code in the _element_constructor_
(right above your changes) become redundant. You should remove them to avoid confusion.
Furthermore, you should adapt the description of the new argument gap_hom
in the docstring of GroupMorphism_libgap
.
If these things are done, you may switch to positive review.
FYI: I will create a ticket depending on this one, soon. Its purpose will be to include permutation groups within the GroupHomset_libgap
setting.
comment:7 Changed 20 months ago by
 Commit changed from b2d9622e20c607355e215d8748d4dba3c88ba7a1 to 21cb66449cd424f94d15bd695fa986a0ce40c30c
Branch pushed to git repo; I updated commit sha1. New commits:
21cb664  correct docstring for argument `gap_hom`

comment:8 Changed 20 months ago by
 Milestone changed from sage8.4 to sage8.5
 Status changed from needs_review to positive_review
Thanks for doing the review Sebastian. Simon, sorry that this fell off my radar.
comment:9 Changed 20 months ago by
 Branch changed from u/sbrandhorst/more_flexible_constructor_of__grouphomomorphisms to 21cb66449cd424f94d15bd695fa986a0ce40c30c
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
a doctest