Opened 4 years ago
Closed 4 years ago
#26347 closed defect (fixed)
clean deprecation warning in doctests for paths.py + animate.py
Reported by: | slabbe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.4 |
Component: | doctest coverage | Keywords: | |
Cc: | Merged in: | ||
Authors: | Sébastien Labbé | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 3567fac (Commits, GitHub, GitLab) | Commit: | 3567fac891031bcb31fb547a2c7a7d4e6dda9e2c |
Dependencies: | Stopgaps: |
Description
With ffmpeg and imagemagick installed, the command:
sage -tp --long --optional=sage,optional,external src/sage/plot/animate.py src/sage/combinat/words/paths.py
gives:
sage -t --long src/sage/plot/animate.py ********************************************************************** File "src/sage/plot/animate.py", line 879, in sage.plot.animate.Animation.? Failed example: a.ffmpeg(output_format='gif',delay=30,iterations=5) # optional -- ffmpeg Expected: doctest:...: DeprecationWarning: use tmp_filename instead See http://trac.sagemath.org/17234 for details. Got: <BLANKLINE> ********************************************************************** 1 item had failures: 1 of 15 in sage.plot.animate.Animation.? 5 tests skipped [236 tests, 1 failure, 147.88 s] sage -t --long src/sage/combinat/words/paths.py ********************************************************************** File "src/sage/combinat/words/paths.py", line 1611, in sage.combinat.words.paths.FiniteWordPath_2d.animate Failed example: a.gif(delay=35, iterations=3) # optional -- ImageMagick Expected: doctest:...: DeprecationWarning: use tmp_filename instead See http://trac.sagemath.org/17234 for details. Got: <BLANKLINE> ********************************************************************** 1 item had failures: 1 of 19 in sage.combinat.words.paths.FiniteWordPath_2d.animate 1 test skipped [523 tests, 1 failure, 106.69 s]
Change History (3)
comment:1 Changed 4 years ago by
- Branch set to u/slabbe/26347
- Commit set to 3567fac891031bcb31fb547a2c7a7d4e6dda9e2c
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:3 Changed 4 years ago by
- Branch changed from u/slabbe/26347 to 3567fac891031bcb31fb547a2c7a7d4e6dda9e2c
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
26347: clean old deprecation warnings in doctests