Changes between Initial Version and Version 1 of Ticket #26344, comment 36


Ignore:
Timestamp:
10/03/18 14:28:04 (3 years ago)
Author:
gh-ehaka
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26344, comment 36

    initial v1  
    11Ah, I didn't know about the groups catalog, this is a very good solution, thanks! I fixed a typo in the catalog and removed the now empty file `lie_gps/all.py`
    22
    3 I modified the `_repr_` method of Lie group elements to avoid unnecessarily calling `chart_exp2` in case the default chart is `_Exp1`, since the computation is quite expensive.
     3I modified the `_repr_` method of Lie group elements to avoid unnecessarily calling `chart_exp2` in case the default chart is `_Exp1`, since the computation is quite expensive. Although the current form is not ideal either, since now if the default coordinate chart is something other than `chart_exp2` or `_Exp1`, then it will still unnecessarily compute the transitions to and from exp-2 coordinates. Not sure how to handle this without the `_Exp2=None` default.
    44
    5 Other than that, the changes look good to me!
     5Other than that, the changes look good to me.