Opened 3 years ago

Closed 18 months ago

#26332 closed defect (fixed)

Remove the ore_algebra optional package

Reported by: tmonteil Owned by:
Priority: major Milestone: sage-9.0
Component: packages: optional Keywords: upgrade, ore_algebra
Cc: mkauers, mmezzarobba, slelievre Merged in:
Authors: Thierry Monteil, Marc Mezzarobba Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 1f64d51 (Commits, GitHub, GitLab) Commit: 1f64d51c83d6fa8c56c8aaaf4ed77a743525a938
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

The version shipped by Sage has been out of date for a while and periodically breaks when Sage makes incompatible changes, while up-to-date versions can easily be installed from pip.

Now pip-available from https://github.com/mkauers/ore_algebra

Change History (20)

comment:1 Changed 3 years ago by tmonteil

  • Branch set to u/tmonteil/fetch_ore_algebra_directly_from_upstream

comment:2 Changed 3 years ago by tmonteil

  • Commit set to ff802e25faccea8fcffd614f258c78c2a5e2b426
  • Status changed from new to needs_review

New commits:

ff802e226332 : fetch ore_algebra directly from upstream

comment:3 in reply to: ↑ description Changed 3 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Replying to tmonteil:

(A) ore_algebra 0.3 is not working with Sage for a wile and upstream does not release versions anymore.

(B) Hence, we should [...] fetch ore_algebra directly from upstream.

I don't see how premise (A) implies conclusion (B). There are other packages that don't have releasea and which are still packaged normally.

Last edited 3 years ago by jdemeyer (previous) (diff)

comment:4 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 2 years ago by slelievre

  • Cc slelievre added
  • Description modified (diff)
  • Keywords upgrade ore_algebra added
  • Milestone changed from sage-8.4 to sage-8.8
  • Summary changed from fetch ore_algebra directly from upstream to Upgrade: ore_algebra 0.4

New version: ore_algebra 0.4 was released on 2019-05-17.

Can someone test whether it installs and works with current Sage?

comment:6 Changed 2 years ago by slelievre

  • Cc mkauers mmezzarobba added
  • Description modified (diff)

comment:7 Changed 2 years ago by mmezzarobba

  • Authors changed from Thierry Monteil to Thierry Monteil, Marc Mezzarobba
  • Branch changed from u/tmonteil/fetch_ore_algebra_directly_from_upstream to u/mmezzarobba/remove_ore_algebra
  • Commit changed from ff802e25faccea8fcffd614f258c78c2a5e2b426 to 8de39b6ce953bf47fbd7795692ff796f8050dbd0
  • Description modified (diff)
  • Summary changed from Upgrade: ore_algebra 0.4 to Remove the ore_algebra optional package

Not tested.


New commits:

8de39b6#26332 Remove the ore_algebra package

comment:8 Changed 2 years ago by mmezzarobba

  • Description modified (diff)

comment:9 follow-up: Changed 2 years ago by jdemeyer

Why remove the package instead of upgrading, as Samuel proposed?

comment:10 in reply to: ↑ 9 ; follow-up: Changed 2 years ago by mmezzarobba

Replying to jdemeyer:

Why remove the package instead of upgrading, as Samuel proposed?

It is an external package with a dependency on Sage. I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package. And while I try to make sure that the master branch always works with the latest Sage release, the Sage package is broken half of the time. If someone wants to take care of it on a regular basis (and bug Manuel to tag a point release every time something breaks), that's fine with me of course, but that hasn't been the case in the last few years.

comment:11 in reply to: ↑ 10 ; follow-up: Changed 2 years ago by jdemeyer

Replying to mmezzarobba:

I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package.

There are many packages for which this argument could be made, but we still ship them as Sage packages. The advantages of having a Sage package are user friendliness (sage -i ore_algebra works) and automatic updates with version checking.

I try to make sure that the master branch always works with the latest Sage release

But not everybody uses the latest Sage release. You may break stuff if a newer version of ore_algebra doesn't work with an older version of Sage.

comment:12 in reply to: ↑ 11 Changed 2 years ago by mmezzarobba

Replying to jdemeyer:

Replying to mmezzarobba:

I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package.

There are many packages for which this argument could be made, but we still ship them as Sage packages. The advantages of having a Sage package are user friendliness (sage -i ore_algebra works) and automatic updates with version checking.

If it works, yes, except that I personally consider sage -i a strictly less user-friendly option than sage -pip install (< pip install < apt install).

I try to make sure that the master branch always works with the latest Sage release

But not everybody uses the latest Sage release. You may break stuff if a newer version of ore_algebra doesn't work with an older version of Sage.

Yes, of course. I'm alking about the master branch... Fwiw I also try to keep it compatible with earlier versions when that's easy to do.

comment:13 Changed 2 years ago by mmezzarobba

  • Status changed from needs_work to needs_review

(If anyone really considers it important to have ore_algebra as a Sage package, feel free to revert my changes to this ticket.)

Version 0, edited 2 years ago by mmezzarobba (next)

comment:14 Changed 2 years ago by mmezzarobba

So: If someone prefers the status quo or Thierry's original solution to removing the package, could you please state it clearly? Otherwise, this should be an easy review... Thanks!

comment:15 Changed 2 years ago by embray

  • Milestone changed from sage-8.8 to sage-8.9

Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).

comment:16 Changed 18 months ago by git

  • Commit changed from 8de39b6ce953bf47fbd7795692ff796f8050dbd0 to 1f64d51c83d6fa8c56c8aaaf4ed77a743525a938

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1f64d51#26332 Remove the ore_algebra package

comment:17 Changed 18 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it go

comment:18 Changed 18 months ago by chapoton

  • Description modified (diff)
  • Reviewers Frédéric Chapoton deleted

comment:19 Changed 18 months ago by chapoton

  • Milestone changed from sage-8.9 to sage-9.0
  • Reviewers set to Frédéric Chapoton

comment:20 Changed 18 months ago by vbraun

  • Branch changed from u/mmezzarobba/remove_ore_algebra to 1f64d51c83d6fa8c56c8aaaf4ed77a743525a938
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.