Opened 3 years ago
Closed 20 months ago
#26332 closed defect (fixed)
Remove the ore_algebra optional package
Reported by:  tmonteil  Owned by:  

Priority:  major  Milestone:  sage9.0 
Component:  packages: optional  Keywords:  upgrade, ore_algebra 
Cc:  mkauers, mmezzarobba, slelievre  Merged in:  
Authors:  Thierry Monteil, Marc Mezzarobba  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  1f64d51 (Commits, GitHub, GitLab)  Commit:  1f64d51c83d6fa8c56c8aaaf4ed77a743525a938 
Dependencies:  Stopgaps: 
Description (last modified by )
The version shipped by Sage has been out of date for a while and periodically breaks when Sage makes incompatible changes, while uptodate versions can easily be installed from pip.
Now pipavailable from https://github.com/mkauers/ore_algebra
Change History (20)
comment:1 Changed 3 years ago by
 Branch set to u/tmonteil/fetch_ore_algebra_directly_from_upstream
comment:2 Changed 3 years ago by
 Commit set to ff802e25faccea8fcffd614f258c78c2a5e2b426
 Status changed from new to needs_review
comment:3 in reply to: ↑ description Changed 3 years ago by
 Status changed from needs_review to needs_work
Replying to tmonteil:
(A)
ore_algebra
0.3 is not working with Sage for a wile and upstream does not release versions anymore.
(B) Hence, we should [...] fetch
ore_algebra
directly from upstream.
I don't see how premise (A) implies conclusion (B). There are other packages that don't have releasea and which are still packaged normally.
comment:4 Changed 3 years ago by
 Description modified (diff)
comment:5 Changed 2 years ago by
 Cc slelievre added
 Description modified (diff)
 Keywords upgrade ore_algebra added
 Milestone changed from sage8.4 to sage8.8
 Summary changed from fetch ore_algebra directly from upstream to Upgrade: ore_algebra 0.4
New version: ore_algebra
0.4 was released on 20190517.
Can someone test whether it installs and works with current Sage?
comment:6 Changed 2 years ago by
 Cc mkauers mmezzarobba added
 Description modified (diff)
comment:7 Changed 2 years ago by
 Branch changed from u/tmonteil/fetch_ore_algebra_directly_from_upstream to u/mmezzarobba/remove_ore_algebra
 Commit changed from ff802e25faccea8fcffd614f258c78c2a5e2b426 to 8de39b6ce953bf47fbd7795692ff796f8050dbd0
 Description modified (diff)
 Summary changed from Upgrade: ore_algebra 0.4 to Remove the ore_algebra optional package
comment:8 Changed 2 years ago by
 Description modified (diff)
comment:9 followup: ↓ 10 Changed 2 years ago by
Why remove the package instead of upgrading, as Samuel proposed?
comment:10 in reply to: ↑ 9 ; followup: ↓ 11 Changed 2 years ago by
Replying to jdemeyer:
Why remove the package instead of upgrading, as Samuel proposed?
It is an external package with a dependency on Sage. I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package. And while I try to make sure that the master branch always works with the latest Sage release, the Sage package is broken half of the time. If someone wants to take care of it on a regular basis (and bug Manuel to tag a point release every time something breaks), that's fine with me of course, but that hasn't been the case in the last few years.
comment:11 in reply to: ↑ 10 ; followup: ↓ 12 Changed 2 years ago by
Replying to mmezzarobba:
I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package.
There are many packages for which this argument could be made, but we still ship them as Sage packages. The advantages of having a Sage package are user friendliness (sage i ore_algebra
works) and automatic updates with version checking.
I try to make sure that the master branch always works with the latest Sage release
But not everybody uses the latest Sage release. You may break stuff if a newer version of ore_algebra
doesn't work with an older version of Sage.
comment:12 in reply to: ↑ 11 Changed 2 years ago by
Replying to jdemeyer:
Replying to mmezzarobba:
I think people should install it from pip or whatever they like; I don't see the point of having it as a Sage package.
There are many packages for which this argument could be made, but we still ship them as Sage packages. The advantages of having a Sage package are user friendliness (
sage i ore_algebra
works) and automatic updates with version checking.
If it works, yes, except that I personally consider sage i
a strictly less userfriendly option than sage pip install
(< pip install
< apt install
).
I try to make sure that the master branch always works with the latest Sage release
But not everybody uses the latest Sage release. You may break stuff if a newer version of
ore_algebra
doesn't work with an older version of Sage.
Yes, of course. I'm alking about the master branch... Fwiw I also try to keep it compatible with earlier versions when that's easy to do.
comment:13 Changed 2 years ago by
 Status changed from needs_work to needs_review
(If anyone really considers it important to have ore_algebra as a Sage package, feel free to revert my changes to this ticket.)
PS regarding Thierry's version: I personally don't like the idea of a “package” that actually installs a version that was not checked by the packager, but I won't argue if people want that.
comment:14 Changed 2 years ago by
So: If someone prefers the status quo or Thierry's original solution to removing the package, could you please state it clearly? Otherwise, this should be an easy review... Thanks!
comment:15 Changed 2 years ago by
 Milestone changed from sage8.8 to sage8.9
Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).
comment:16 Changed 20 months ago by
 Commit changed from 8de39b6ce953bf47fbd7795692ff796f8050dbd0 to 1f64d51c83d6fa8c56c8aaaf4ed77a743525a938
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
1f64d51  #26332 Remove the ore_algebra package

comment:17 Changed 20 months ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, let it go
comment:18 Changed 20 months ago by
 Description modified (diff)
 Reviewers Frédéric Chapoton deleted
comment:19 Changed 20 months ago by
 Milestone changed from sage8.9 to sage9.0
 Reviewers set to Frédéric Chapoton
comment:20 Changed 20 months ago by
 Branch changed from u/mmezzarobba/remove_ore_algebra to 1f64d51c83d6fa8c56c8aaaf4ed77a743525a938
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
26332 : fetch ore_algebra directly from upstream