Opened 4 years ago

Closed 4 years ago

#26328 closed enhancement (fixed)

py3: tiny fix in species

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 07b7ba7 (Commits, GitHub, GitLab) Commit: 07b7ba76e96dad75740df6d223da41e642fcb913
Dependencies: Stopgaps:

Status badges


to bypass the problem in #26327

Change History (5)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/26328
  • Commit set to 07b7ba76e96dad75740df6d223da41e642fcb913
  • Status changed from new to needs_review

New commits:

07b7ba7py3: one tiny fix in species

comment:2 Changed 4 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

This isn't just a py3 fix, but brittle code overall. It should have been explicit about what basis it wants. LGTM.

comment:4 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/26328 to 07b7ba76e96dad75740df6d223da41e642fcb913
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.