Opened 3 years ago

Closed 3 years ago

#26321 closed defect (fixed)

py3: hodgepodge of (mostly) trivial doctest fixes

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.4
Component: python3 Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f1f5d16 (Commits, GitHub, GitLab) Commit: f1f5d16862f81839aa4b396c266d2ebc9be98fa1
Dependencies: #26390 Stopgaps:

Status badges

Description

Just adding more fixes from my python3 branch.

There's no unifying theme to these fixes except that they are mostly either tests that fail due to trivial output differences, or that make no sense on Python 3 in the first place (e.g. having to do with long, or old-style classes, etc.)

If any of them need a closer look I'm happy to split them out, but I don't think most of them are very interesting.

Change History (11)

comment:1 Changed 3 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by chapoton

likely to conflict with #26316

comment:3 Changed 3 years ago by chapoton

Could you please split at least the misc/ part into another ticket ?

In #26212, one tries to organise the work folder by folder.

comment:4 Changed 3 years ago by embray

  • Status changed from needs_review to needs_work

Yes, I've also tried to do things mostly on a basis of top-level sub-packages. In this case there were just so many, and most of them very small (like, one liners) that I didn't feel like making a bunch of tickets.

I could split the misc/ ones off, but what about the others? It still doesn't really solve the problem.

I think for the one in sage.algebras.commutative_dga I prefer the approach of testing the two cases separately, rather than cutting off most of the contents of the exception message. But I can rebase on top of #26316 and adjust that.

comment:5 Changed 3 years ago by chapoton

branch does not apply..

comment:6 Changed 3 years ago by embray

Well, sure, there was just a new release so I guess that may be.

comment:7 Changed 3 years ago by chapoton

I have split off the changes in misc, see #26390

comment:8 Changed 3 years ago by chapoton

  • Branch changed from u/embray/python3/doctests/misc to public/26321
  • Commit changed from 486e529971793f727cca7fbe5ef1d3f33d4d4bb6 to d608060dbb4355b862a056910df713adf0ddbead
  • Status changed from needs_work to needs_review

New commits:

​d608060Merge branch 'u/embray/python3/doctests/misc' in 8.4.b7

comment:9 Changed 3 years ago by git

  • Commit changed from d608060dbb4355b862a056910df713adf0ddbead to f1f5d16862f81839aa4b396c266d2ebc9be98fa1

Branch pushed to git repo; I updated commit sha1. New commits:

​f1f5d16fix bad merge

comment:10 Changed 3 years ago by tscrim

  • Dependencies set to #26390
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I am assuming #26390 is a dependency. LGTM.

comment:11 Changed 3 years ago by vbraun

  • Branch changed from public/26321 to f1f5d16862f81839aa4b396c266d2ebc9be98fa1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.