Opened 7 months ago
Closed 7 months ago
#26316 closed defect (fixed)
py3: doctests for commutative_dga.py
Reported by: | jhpalmieri | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.4 |
Component: | python3 | Keywords: | |
Cc: | chapoton, tscrim | Merged in: | |
Authors: | John Palmieri | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 3deb7a0 (Commits) | Commit: | 3deb7a0cdabd9568fef827620d85dd8ac8367565 |
Dependencies: | Stopgaps: |
Description
Fix the py3 doctests for src/algebras/commutative_dga.py.
Change History (5)
comment:1 Changed 7 months ago by
- Branch set to u/jhpalmieri/dga-py3
comment:2 Changed 7 months ago by
- Commit set to 3deb7a0cdabd9568fef827620d85dd8ac8367565
comment:3 Changed 7 months ago by
- Status changed from new to needs_review
comment:4 Changed 7 months ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:5 Changed 7 months ago by
- Branch changed from u/jhpalmieri/dga-py3 to 3deb7a0cdabd9568fef827620d85dd8ac8367565
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
There are three changes: change
d.iteritems()
tod.items()
in one place – that one is clear, and it's because of a recent change that I made. Second, I see two failures of this form:So I added a
_is_nonzero
method for theDifferential
class. Third, a traceback has a different form in Python 2 compared to Python 3, so I added...
in a suitable place.New commits:
trac 26316: fix py3 doctests for commutative_dga.py.