#26296 closed enhancement (fixed)

removed deprecated N method in element.pyx

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: refactoring Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 65b3f3e (Commits) Commit: 65b3f3ec18e72064e2538c52793f06ae445ee9ce
Dependencies: Stopgaps:

Description

from #13055

  • plus remove __div__ automethod, problematic in python3
  • plus a few other details

Change History (10)

comment:1 Changed 21 months ago by chapoton

  • Branch set to u/chapoton/26296
  • Commit set to 570c963684ed029fa96332813e9d9ce7cdc0363d
  • Status changed from new to needs_review

New commits:

ba118b7remove deprecated N method in element.pyx
570c963remove one import

comment:2 Changed 21 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

So I am fine with everything except the __div__. I feel like for completeness it should be there. Would you be okay with kicking that down the road?

comment:3 Changed 21 months ago by jdemeyer

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Jeroen Demeyer

__div__ is Python 2 only, so I don't mind removing it.

comment:4 Changed 21 months ago by tscrim

  • Status changed from needs_review to positive_review

Okay.

comment:5 Changed 21 months ago by vbraun

sage -t --long src/sage/structure/element.pyx  # 2 doctests failed

comment:6 Changed 21 months ago by tscrim

  • Status changed from positive_review to needs_work

comment:7 Changed 21 months ago by git

  • Commit changed from 570c963684ed029fa96332813e9d9ce7cdc0363d to 65b3f3ec18e72064e2538c52793f06ae445ee9ce

Branch pushed to git repo; I updated commit sha1. New commits:

65b3f3etrac 26296 fixing doctests

comment:8 Changed 21 months ago by chapoton

  • Status changed from needs_work to needs_review

fixed

comment:9 Changed 21 months ago by tscrim

  • Status changed from needs_review to positive_review

Verified.

comment:10 Changed 21 months ago by vbraun

  • Branch changed from u/chapoton/26296 to 65b3f3ec18e72064e2538c52793f06ae445ee9ce
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.