Opened 2 years ago
Last modified 7 weeks ago
#26293 needs_work enhancement
k_combinat: skew_partition
Reported by:  ghMareoRaft  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  combinatorics  Keywords:  k combinat 
Cc:  ghseeli  Merged in:  
Authors:  Matthew Lancellotti  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  public/k_combinat/skew_partition/26293 (Commits)  Commit:  71b43f7382530a0730ce2325b0917eb0be3931e9 
Dependencies:  Stopgaps: 
Description (last modified by )
The skew_partition.py
portion of the migration of the k_combinat_for_sage (https://github.com/MareoRaft/k_combinat_for_sage) project into core sage (see also the mother ticket #25295).
This branch is *now ready* for review :)
Your mission, should you choose to accept, is to review is the functions
is_symmetric
right
left
top
bottom
is_linked
k_boundary_to_partition
is_k_boundary
row_shape_to_linked_skew_partitions
size_to_linked_skew_partitions
which are all located in the file src/sage/combinat/skew_partition.py
.
Change History (10)
comment:1 Changed 2 years ago by
 Branch set to public/k_combinat/skew_partition/26293
 Commit set to aafa1ce2b278ad3a4b953e820a49a68c92b11b4e
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 2 years ago by
 Description modified (diff)
comment:3 Changed 2 years ago by
There is a change I haven't done yet but want an opinion on:
There are two functions (row_shape_to_linked_skew_partitions
and size_to_linked_skew_partitions
) which I haven't fit into the standard objectoriented organization...
I think the most appropriate thing would be to create a new class LinkedSkewPartition
which subclasses SkewPartition
and merely adds the additional restriction is_linked
to the constructor. There would also be a class called LinkedSkewPartitions
which would have the methods init_from_row_shape
and init_from_size
, which would be my two functions.
Let me know if you think this is a good idea.
comment:4 Changed 2 years ago by
 Commit changed from aafa1ce2b278ad3a4b953e820a49a68c92b11b4e to 5c5f09a5db193a160c0dc7ee9329efb7a4390c9b
Branch pushed to git repo; I updated commit sha1. New commits:
5c5f09a  tests passing

comment:5 Changed 2 years ago by
 Commit changed from 5c5f09a5db193a160c0dc7ee9329efb7a4390c9b to 44d5f070624d12f9255f6e0d11ffa3f0faf1808e
comment:7 Changed 2 years ago by
 Description modified (diff)
 Status changed from new to needs_review
comment:8 Changed 2 years ago by
 Commit changed from 44d5f070624d12f9255f6e0d11ffa3f0faf1808e to 71b43f7382530a0730ce2325b0917eb0be3931e9
Branch pushed to git repo; I updated commit sha1. New commits:
a139803  newline beginning docstrings, _Partitions instead of Partition, self first param of methods, error messages frags

b9ebcfe  variable in docstring should be self

89dd51b  Merge branch 'public/k_combinat/skew_partition/26293' of git://trac.sagemath.org/sage into public/k_combinat/skew_partition/26293

71b43f7  remove k_shape.py, that was meant for another branch

comment:9 Changed 4 months ago by
 Milestone changed from sage8.4 to sage9.2
 Status changed from needs_review to needs_work
red branch => needs_work
comment:10 Changed 7 weeks ago by
 Milestone changed from sage9.2 to sage9.3
New commits:
first commit. testing.
test 2. non code change.
unit tests for partition passing. next need to run sage tests.
sage tests passing
newest docstrings, newest changed to k_combinat_for_sage, and tests added
simply moved all the methods as one giant chunk to a more appropriate place. the git diff looks really complicated though because git can be 'stupid' at times.
references
added author