Opened 4 years ago
Closed 4 years ago
#26285 closed enhancement (fixed)
Avoid comparison of vertex labels in MIP (Step 4)
Reported by:  David Coudert  Owned by:  

Priority:  major  Milestone:  sage8.4 
Component:  graph theory  Keywords:  
Cc:  Travis Scrimshaw, Frédéric Chapoton  Merged in:  
Authors:  David Coudert  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  69cb9d5 (Commits, GitHub, GitLab)  Commit:  69cb9d5bc4202c09c9ec345d966763b5bbbcf98f 
Dependencies:  Stopgaps: 
Description
Avoid comparison of vertex labels in generic_graph.py
.
We also do some cleaning in all MIPs of this file.
Change History (15)
comment:1 Changed 4 years ago by
Branch:  → public/26285_in_generic_graph 

Commit:  → 123ce70626085a4f1dff0f50242ed0de66722941 
Status:  new → needs_review 
comment:2 Changed 4 years ago by
Commit:  123ce70626085a4f1dff0f50242ed0de66722941 → 4adedf8216b20ad16fcc6d9e20d0e013b315cc89 

Branch pushed to git repo; I updated commit sha1. New commits:
4adedf8  trac #26285: resolve merge conflict with 8.4.beta5

comment:3 Changed 4 years ago by
Commit:  4adedf8216b20ad16fcc6d9e20d0e013b315cc89 → 06a79d323aeb3e8e0c51ea89b8cde7424a8f6c11 

Branch pushed to git repo; I updated commit sha1. New commits:
06a79d3  trac #26285: turn some lambda statements to def

comment:5 Changed 4 years ago by
Cc:  Travis Scrimshaw Frédéric Chapoton added 

comment:6 Changed 4 years ago by
Commit:  06a79d323aeb3e8e0c51ea89b8cde7424a8f6c11 → 661d8079f29ade36afe01f775b1b97b983e7b140 

comment:8 Changed 4 years ago by
Are these little helper functions useful? They don't seem to really improve the code readability IMO now.
def f_edge_used(u, v): return edge_used[frozenset((u,v))]
def B(u,v): return b[frozenset((u,v))]
Otherwise LGTM.
comment:9 Changed 4 years ago by
Reviewers:  → Travis Scrimshaw 

comment:10 Changed 4 years ago by
Commit:  661d8079f29ade36afe01f775b1b97b983e7b140 → 69cb9d5bc4202c09c9ec345d966763b5bbbcf98f 

Branch pushed to git repo; I updated commit sha1. New commits:
69cb9d5  trac #26285: implement reviewer's comments

comment:13 Changed 4 years ago by
Status:  needs_review → positive_review 

comment:15 Changed 4 years ago by
Branch:  public/26285_in_generic_graph → 69cb9d5bc4202c09c9ec345d966763b5bbbcf98f 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
trac #26285: avoid comparison of vertex labels in MIPs of generic_graph