Opened 6 months ago
Closed 6 months ago
#26285 closed enhancement (fixed)
Avoid comparison of vertex labels in MIP (Step 4)
Reported by:  dcoudert  Owned by:  

Priority:  major  Milestone:  sage8.4 
Component:  graph theory  Keywords:  
Cc:  tscrim, chapoton  Merged in:  
Authors:  David Coudert  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  69cb9d5 (Commits)  Commit:  69cb9d5bc4202c09c9ec345d966763b5bbbcf98f 
Dependencies:  Stopgaps: 
Description
Avoid comparison of vertex labels in generic_graph.py
.
We also do some cleaning in all MIPs of this file.
Change History (15)
comment:1 Changed 6 months ago by
 Branch set to public/26285_in_generic_graph
 Commit set to 123ce70626085a4f1dff0f50242ed0de66722941
 Status changed from new to needs_review
comment:2 Changed 6 months ago by
 Commit changed from 123ce70626085a4f1dff0f50242ed0de66722941 to 4adedf8216b20ad16fcc6d9e20d0e013b315cc89
Branch pushed to git repo; I updated commit sha1. New commits:
4adedf8  trac #26285: resolve merge conflict with 8.4.beta5

comment:3 Changed 6 months ago by
 Commit changed from 4adedf8216b20ad16fcc6d9e20d0e013b315cc89 to 06a79d323aeb3e8e0c51ea89b8cde7424a8f6c11
Branch pushed to git repo; I updated commit sha1. New commits:
06a79d3  trac #26285: turn some lambda statements to def

comment:4 Changed 6 months ago by
Issues reported by pyflakes test are addressed in #26289.
comment:5 Changed 6 months ago by
 Cc tscrim chapoton added
comment:6 Changed 6 months ago by
 Commit changed from 06a79d323aeb3e8e0c51ea89b8cde7424a8f6c11 to 661d8079f29ade36afe01f775b1b97b983e7b140
comment:7 Changed 6 months ago by
comment:8 Changed 6 months ago by
Are these little helper functions useful? They don't seem to really improve the code readability IMO now.
def f_edge_used(u, v): return edge_used[frozenset((u,v))]
def B(u,v): return b[frozenset((u,v))]
Otherwise LGTM.
comment:9 Changed 6 months ago by
 Reviewers set to Travis Scrimshaw
comment:10 Changed 6 months ago by
 Commit changed from 661d8079f29ade36afe01f775b1b97b983e7b140 to 69cb9d5bc4202c09c9ec345d966763b5bbbcf98f
Branch pushed to git repo; I updated commit sha1. New commits:
69cb9d5  trac #26285: implement reviewer's comments

comment:11 Changed 6 months ago by
I have modified the methods.
comment:12 Changed 6 months ago by
LGTM. Thanks.
comment:13 Changed 6 months ago by
 Status changed from needs_review to positive_review
comment:14 Changed 6 months ago by
Thank you very much!
comment:15 Changed 6 months ago by
 Branch changed from public/26285_in_generic_graph to 69cb9d5bc4202c09c9ec345d966763b5bbbcf98f
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
trac #26285: avoid comparison of vertex labels in MIPs of generic_graph