Opened 4 years ago

Closed 4 years ago

#26283 closed defect (fixed)

py3: minor fixes and refactoring in sage.schemes.affine

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.4
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Erik Bray Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: c2768a9 (Commits, GitHub, GitLab) Commit: c2768a900ff531febb2af002fcdff84f1bc59992
Dependencies: Stopgaps:

Status badges

Description


Change History (5)

comment:1 Changed 4 years ago by embray

Status: newneeds_review

comment:2 Changed 4 years ago by chapoton

Cc: tscrim added
  • why the changes in affine_homset.py ?
  • the hash in affine_point.py is maybe not so good. Something similar has been discussed (but nothing was done) in #26188

comment:3 in reply to:  2 Changed 4 years ago by embray

Replying to chapoton:

  • why the changes in affine_homset.py ?

I think the answers to these questions can be found in the commit log.

  • the hash in affine_point.py is maybe not so good. Something similar has been discussed (but nothing was done) in #26188

Then that should be a separate issue. All I care about here is the fact that it currently does not return a Python int as required.

comment:4 Changed 4 years ago by chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok..

comment:5 Changed 4 years ago by vbraun

Branch: u/embray/python3/sage-schemes-affine/miscc2768a900ff531febb2af002fcdff84f1bc59992
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.