Opened 4 years ago
Closed 4 years ago
#26275 closed enhancement (fixed)
py3: Fix categories/regular_supercrystals.py for python3
Reported by: | vklein | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.4 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | Vincent Klein | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | da30802 (Commits, GitHub, GitLab) | Commit: | da30802fe1baae3b28896e06036f3430087d819f |
Dependencies: | Stopgaps: |
Description (last modified by )
- Sort result of Digraph.sinks().
- Fix regular_supercrystals.py doctests.
- In type_Q.py CartanType?.index_set, fix range usage as a list (it's an iterator in python3).
An unique doctest error is remaining but it should be fixed by #26267
Change History (13)
comment:1 Changed 4 years ago by
Branch: | → u/vklein/py3_supercrystal |
---|
comment:2 Changed 4 years ago by
Commit: | → 629fe2d4cf0512e9e4c49a5d166f8baddc1c90f2 |
---|---|
Description: | modified (diff) |
comment:3 Changed 4 years ago by
Status: | new → needs_review |
---|
comment:4 Changed 4 years ago by
Authors: | → Vincent Klein |
---|
comment:5 Changed 4 years ago by
+1 to the other changes but strong -1 to sorting the sinks()
. The vertices (and hence the output) may not be sortable. The better thing to do in this case is to either directly call sorted
on the offending doctests (which I don't really care for, but you cannot get around that for a non-deterministic doctest) or add a sort=False
keyword to sinks()
. Anyways, the changes to sinks()
should be done on a separate ticket for better separations-of-concerns and matched with a corresponding change to sources
and similar methods.
comment:6 Changed 4 years ago by
Status: | needs_review → needs_work |
---|
comment:7 Changed 4 years ago by
Commit: | 629fe2d4cf0512e9e4c49a5d166f8baddc1c90f2 → 71986e26ae16367b42706a81df4870cbd699756f |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
71986e2 | Trac #26275 : Revert Digraph.sink() modification ...
|
comment:8 Changed 4 years ago by
Status: | needs_work → needs_review |
---|
Changes to sinks()
reverted. I sorted the doctest results instead.
comment:9 Changed 4 years ago by
I get a doctest failure due to this change:
sage: T = B.tensor(B) sage: T.lowest_weight_vectors() - ([3, 3], [3, 2]) + ([3, 2], [3, 3])
Did you want a sorted
on that output as well?
comment:10 Changed 4 years ago by
Commit: | 71986e26ae16367b42706a81df4870cbd699756f → da30802fe1baae3b28896e06036f3430087d819f |
---|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
da30802 | Trac #26275 : Revert Digraph.sink() modification ...
|
comment:11 Changed 4 years ago by
Apparently py2 test have not be done with 71986e2
. Sorry for that.
da30802
fix the problem.
comment:12 Changed 4 years ago by
Reviewers: | → Travis Scrimshaw |
---|---|
Status: | needs_review → positive_review |
Thank you.
comment:13 Changed 4 years ago by
Branch: | u/vklein/py3_supercrystal → da30802fe1baae3b28896e06036f3430087d819f |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
New commits:
Trac #26275 : Fix categories/regular_supercrystals.py ...