#26264 closed defect (fixed)

py3: fixes for the hypergeometric() symbolic function

Reported by: embray Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: chapoton Merged in:
Authors: Erik Bray Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 362b419 (Commits) Commit: 362b41949c957796e7b1d768b5e0838f13759000
Dependencies: Stopgaps:

Description

(includes some trivial whitespace cleanup on a file that otherwise didn't require any fixes for now, but that I happened to be looking at while fixing the real issue)

Change History (10)

comment:1 Changed 21 months ago by embray

  • Status changed from new to needs_review

comment:2 Changed 21 months ago by git

  • Commit changed from 2ba344a3a4c56c03989ec28a3bb885d810e265ee to e42be3fd20783bea72513a42abfed4986fc061c0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6335569py3: fix some map() calls that broke hypergeometric()
e42be3ftrivial whitespace and pep-8 cleanup in this module

comment:3 Changed 21 months ago by git

  • Commit changed from e42be3fd20783bea72513a42abfed4986fc061c0 to 6151e6e40a5aeab2333952dfbb73dd4ede320c08

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7eac53bpy3: fix some map() calls that broke hypergeometric()
6151e6etrivial whitespace and pep-8 cleanup in this module

comment:4 Changed 21 months ago by embray

(patched/rebased a couple times after realizing a couple other simplifications I could make)

comment:5 Changed 21 months ago by chapoton

looks good ; if the patchbot comes back green, you can set to positive in my name

comment:6 Changed 21 months ago by chapoton

bot is morally green.

could you please clean the 2 pyflakes warning, and then you can set to positive

comment:7 Changed 21 months ago by chapoton

  • Branch changed from u/embray/python3/sage-functions-hypergeometric to public/ticket/26264
  • Commit changed from 6151e6e40a5aeab2333952dfbb73dd4ede320c08 to 362b41949c957796e7b1d768b5e0838f13759000

I have fixed the pyflakes warnings. Waiting now for patchbot's approval.


New commits:

362b419fixing 2 pyflakes warnings

comment:8 Changed 21 months ago by chapoton

  • Status changed from needs_review to positive_review

ok, good to go

comment:9 Changed 21 months ago by chapoton

  • Reviewers set to Frédéric Chapoton

comment:10 Changed 21 months ago by vbraun

  • Branch changed from public/ticket/26264 to 362b41949c957796e7b1d768b5e0838f13759000
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.