Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26252 closed defect (fixed)

minor flint fixes

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.4
Component: packages: standard Keywords: flint
Cc: slelievre, wbhart, gh-lwhsu Merged in:
Authors: Dima Pasechnik Reviewers: Li-Wen Hsu
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: 340cfaa (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by dimpase)

there is a place where it mixes CFLAGS with CXXFLAGS

see ​https://github.com/wbhart/flint2/pull/501 for the proposed upstream change

Change History (9)

comment:1 Changed 4 years ago by dimpase

Status: new → needs_review

comment:2 Changed 4 years ago by slelievre

Cc: slelievre wbhart added
Keywords: flint added

comment:3 Changed 4 years ago by git

Commit: eee6e0405131530a3b90005dbea82d232d01cee9 → afed27d321b40c9d3b09dcc1b9f084ef3a8138d4

Branch pushed to git repo; I updated commit sha1. New commits:

​afed27ddo not touch SunOS stuff here

comment:4 Changed 4 years ago by dimpase

Description: modified (diff)
Report Upstream: N/A → Reported upstream. No feedback yet.

comment:5 Changed 4 years ago by git

Commit: afed27d321b40c9d3b09dcc1b9f084ef3a8138d4 → 340cfaae05be4131ceae3a0f71fdf96ad865fb15

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​340cfaado not touch SunOS here

comment:6 Changed 4 years ago by dimpase

Cc: gh-lwhsu added
Report Upstream: Reported upstream. No feedback yet. → Fixed upstream, in a later stable release.

comment:7 Changed 4 years ago by gh-lwhsu

Reviewers: → Li-Wen Hsu
Status: needs_review → positive_review

comment:8 Changed 4 years ago by vbraun

Branch: u/dimpase/flintCXXFLAGS → 340cfaae05be4131ceae3a0f71fdf96ad865fb15
Resolution: → fixed
Status: positive_review → closed

comment:9 Changed 4 years ago by gh-dimpase

Commit: 340cfaae05be4131ceae3a0f71fdf96ad865fb15

For the new FreeBSD 12.0, this fails, still, because the recognition of FreeBSD fails, and CXXFLAGS become a copy of CFLAGS (with std=c99, something that is an error on clang++ 6.0.1).

Note: See TracTickets for help on using tickets.