Opened 3 years ago

Closed 3 years ago

#26250 closed defect (fixed)

rubiks makefile should use MAKE

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.4
Component: packages: standard Keywords:
Cc: fbissey Merged in:
Authors: Dima Pasechnik Reviewers: Li-Wen Hsu
Report Upstream: N/A Work issues:
Branch: f99d86f (Commits, GitHub, GitLab) Commit: f99d86fb91ab5e9e4f5661d9328f0d1698aec890
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

If your make is not GNU make, it breaks, as you cannot use MAKE to overwrite make.

Patch made by Li-Wen Hsu here

Change History (4)

comment:1 Changed 3 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/rubiks_MAKE
  • Cc fbissey added
  • Commit set to f99d86fb91ab5e9e4f5661d9328f0d1698aec890
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 3 years ago by dimpase

this is a part of #26249

comment:3 Changed 3 years ago by gh-lwhsu

  • Reviewers set to Li-Wen Hsu
  • Status changed from needs_review to positive_review

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/rubiks_MAKE to f99d86fb91ab5e9e4f5661d9328f0d1698aec890
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.