Opened 3 years ago

Closed 3 years ago

#26248 closed enhancement (fixed)

remove deprecated argument use_eclib in padics elliptic curves

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.4
Component: elliptic curves Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 51c34d2 (Commits, GitHub, GitLab) Commit: 51c34d260075b066954eb49759e5a822075095dd
Dependencies: Stopgaps:

Status badges

Description

from #812

Change History (4)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26248
  • Commit set to 95eac6596c735fd3f38425beb8b11476dac70339
  • Status changed from new to needs_review

New commits:

95eac65remove deprecate argument "use_eclib" in padic elliptic curves

comment:2 Changed 3 years ago by git

  • Commit changed from 95eac6596c735fd3f38425beb8b11476dac70339 to 51c34d260075b066954eb49759e5a822075095dd

Branch pushed to git repo; I updated commit sha1. New commits:

51c34d2trac 26248 fix doctests

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26248 to 51c34d260075b066954eb49759e5a822075095dd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.