Opened 4 years ago

Closed 4 years ago

#26232 closed enhancement (fixed)

enhance pari conversion of elliptic curves over number field

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: elliptic curves Keywords:
Cc: Jeroen Demeyer, John Cremona Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 573f0ef (Commits, GitHub, GitLab) Commit: 573f0ef4f0c6c96fdd5a5460a0649a77eadb7655
Dependencies: Stopgaps:

Status badges

Description

so that their L-function will work in #26098

Change History (8)

comment:1 Changed 4 years ago by Frédéric Chapoton

Branch: u/chapoton/26232
Commit: 573f0ef4f0c6c96fdd5a5460a0649a77eadb7655
Status: newneeds_review

New commits:

573f0efenhance pari conversion of elliptic curves over number fields

comment:2 Changed 4 years ago by Frédéric Chapoton

Cc: John Cremona added

comment:3 Changed 4 years ago by Frédéric Chapoton

any opinion on this change ?

comment:4 Changed 4 years ago by Frédéric Chapoton

I would appreciate some feedback, even quick and dirty..

comment:5 Changed 4 years ago by Frédéric Chapoton

anybody out there ? bot is green, but an opinion from Pari experts is required..

comment:6 Changed 4 years ago by John Cremona

I'm certain that I responded positive several days ago! But there's nothing here so I might have been dreaming. It looks fine to me.

comment:7 Changed 4 years ago by Travis Scrimshaw

Reviewers: John Cremona, Travis Scrimshaw
Status: needs_reviewpositive_review

I will also confirm from a coding perspective this looks good.

comment:8 Changed 4 years ago by Volker Braun

Branch: u/chapoton/26232573f0ef4f0c6c96fdd5a5460a0649a77eadb7655
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.