Opened 3 years ago

Closed 3 years ago

#26232 closed enhancement (fixed)

enhance pari conversion of elliptic curves over number field

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: elliptic curves Keywords:
Cc: jdemeyer, cremona Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 573f0ef (Commits, GitHub, GitLab) Commit: 573f0ef4f0c6c96fdd5a5460a0649a77eadb7655
Dependencies: Stopgaps:

Status badges

Description

so that their L-function will work in #26098

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26232
  • Commit set to 573f0ef4f0c6c96fdd5a5460a0649a77eadb7655
  • Status changed from new to needs_review

New commits:

573f0efenhance pari conversion of elliptic curves over number fields

comment:2 Changed 3 years ago by chapoton

  • Cc cremona added

comment:3 Changed 3 years ago by chapoton

any opinion on this change ?

comment:4 Changed 3 years ago by chapoton

I would appreciate some feedback, even quick and dirty..

comment:5 Changed 3 years ago by chapoton

anybody out there ? bot is green, but an opinion from Pari experts is required..

comment:6 Changed 3 years ago by cremona

I'm certain that I responded positive several days ago! But there's nothing here so I might have been dreaming. It looks fine to me.

comment:7 Changed 3 years ago by tscrim

  • Reviewers set to John Cremona, Travis Scrimshaw
  • Status changed from needs_review to positive_review

I will also confirm from a coding perspective this looks good.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26232 to 573f0ef4f0c6c96fdd5a5460a0649a77eadb7655
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.