Opened 8 months ago

Last modified 2 days ago

#26212 new task

py3: make all tests pass — at Version 154

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.8
Component: python3 Keywords:
Cc: vklein, embray, jmantysalo, gh-timokau Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by vklein)

This ticket is used to keep track of the progress towards python3.

release files having failing doctests more than 100 from 10 to 100 from 1 to 10 failing doctests
8.4.b3 915 42 251 622 17972
8.4.b4 803 23 175 605 10921
8.4.b5 657 17 145 495 8509
8.4.b6 594 17 127 450 7706
8.4.b7 587 17 128 442 7678
8.4.rc0 524 16 119 389 6976
8.5.b0 461 6 94 361 4206
8.5.b1 414 3 76 335 3206
8.5.b2 370 1 66 303 2465
8.5.b3 339 1 62 276 2245
8.5.b4 312 0 58 254 1947
8.5.b5 295 0 51 244 1741
8.5.b6 264 0 43 221 1514

Folders where all tests pass (8.5.b5):

Folders with work in progress:

Change History (155)

comment:1 Changed 8 months ago by chapoton

  • Description modified (diff)

comment:2 Changed 8 months ago by chapoton

  • Description modified (diff)

comment:3 Changed 8 months ago by chapoton

  • Description modified (diff)

comment:4 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:5 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:6 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:7 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:8 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:9 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:10 Changed 7 months ago by jhpalmieri

  • Description modified (diff)

comment:11 Changed 7 months ago by jhpalmieri

  • Description modified (diff)

comment:12 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:13 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:14 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:15 Changed 7 months ago by vklein

  • Cc vklein added

comment:16 Changed 7 months ago by vklein

  • Description modified (diff)

comment:17 Changed 7 months ago by vklein

  • Description modified (diff)

comment:18 Changed 7 months ago by vklein

  • Description modified (diff)

comment:19 Changed 7 months ago by vklein

  • Description modified (diff)

comment:20 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:21 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:22 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:23 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:24 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:25 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:26 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:27 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:28 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:29 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:30 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:31 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:32 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:33 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:34 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:35 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:36 Changed 7 months ago by vklein

  • Description modified (diff)

comment:37 Changed 7 months ago by vklein

  • Description modified (diff)

comment:38 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:39 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:40 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:41 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:42 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:43 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:44 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:45 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:46 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:47 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:48 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:49 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:50 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:51 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:52 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:53 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:54 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:55 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:56 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:57 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:58 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:59 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:60 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:61 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:62 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:63 Changed 7 months ago by chapoton

  • Description modified (diff)

comment:64 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:65 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:66 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:67 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:68 Changed 6 months ago by embray

  • Cc embray added

Hadn't even seen this ticket; very nice.

comment:69 Changed 6 months ago by vklein

  • Description modified (diff)

comment:70 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:71 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:72 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:73 Changed 6 months ago by vklein

  • Description modified (diff)

comment:74 Changed 6 months ago by chapoton

  • Description modified (diff)

good progress on 8.5.b0

comment:75 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:76 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:77 Changed 6 months ago by chapoton

The six remaining files with many failures are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 189 doctests failed',
 'sage -t --long src/sage/dynamics/arithmetic_dynamics/projective_ds.py  # 105 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 110 doctests failed',
 'sage -t --long src/sage/groups/lie_gps/nilpotent_lie_group.py  # 143 doctests failed',
 'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed',
 'sage -t --long src/sage/rings/valuation/limit_valuation.py  # 106 doctests failed']

comment:78 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:79 Changed 6 months ago by jhpalmieri

  • Description modified (diff)

comment:80 follow-up: Changed 6 months ago by jhpalmieri

For whoever wants to work on it, regarding

sage -t --long src/sage/combinat/finite_state_machine.py  # 189 doctests failed

about 150 of the failures can be cured by replacing 'iteritems' by 'items' in lines like

        elif hasattr(data, 'iteritems'):
            # data is a dict (or something similar),

I don't know if 'items' is the right attribute to check, or if it would actually be better to change to isinstance(data, dict). What other data structures are mean to be acceptable? What is "something similar" to a dict?

comment:81 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:82 Changed 6 months ago by vklein

  • Description modified (diff)

comment:83 Changed 6 months ago by vklein

  • Description modified (diff)

comment:84 in reply to: ↑ 80 Changed 6 months ago by vklein

Replying to jhpalmieri:

For whoever wants to work on it, regarding ... I don't know if 'items' is the right attribute to check, or if it would actually be better to change to isinstance(data, dict). What other data structures are mean to be acceptable? What is "something similar" to a dict?

There is some custom "Mapping types" in sage like FreeModuleElement_generic_sparse, which implements items and iteritems but doesn't inherit from dict.

Changed 6 months ago by chapoton

tool to extract the data from patchbot log

comment:85 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:86 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:87 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:88 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:89 Changed 6 months ago by vklein

  • Description modified (diff)

comment:90 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:91 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:92 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:93 Changed 6 months ago by chapoton

There was a regression in the manifolds folder (sigh)..

The 3 remaining files with more than 100 failing doctests are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 182 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 109 doctests failed',
 'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed']

The first one is already tackled in #26147 at least partially.

comment:94 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:95 Changed 6 months ago by jhpalmieri

Regarding

'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed'

I can reproduce those failures when I run ./sage -t ..., but (at least for the first few) not when I run Sage interactively. Odd.

comment:96 Changed 6 months ago by slabbe

  • Description modified (diff)

comment:97 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:98 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:99 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:100 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:101 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:102 Changed 6 months ago by chapoton

  • Description modified (diff)

Top ten bad files in 8.5.b2 are

['sage -t --long src/sage/numerical/backends/cvxopt_sdp_backend.pyx  # 39 doctests failed',
 'sage -t --long src/sage/algebras/iwahori_hecke_algebra.py  # 40 doctests failed',
 'sage -t --long src/sage/numerical/mip.pyx  # 47 doctests failed',
 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'sage -t --long src/sage/rings/function_field/ideal.py  # 56 doctests failed',
 'sage -t --long src/sage/graphs/graph.py  # 59 doctests failed',
 'sage -t --long src/sage/graphs/connectivity.pyx  # 60 doctests failed',
 'sage -t --long src/sage/misc/explain_pickle.py  # 70 doctests failed',
 'sage -t --long src/sage/numerical/sdp.pyx  # 75 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 109 doctests failed']

comment:103 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:104 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:105 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:106 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:107 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:108 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:109 Changed 6 months ago by vklein

  • Description modified (diff)

comment:110 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:111 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:112 Changed 5 months ago by chapoton

  • Milestone changed from sage-8.4 to sage-8.5

comment:113 Changed 5 months ago by vklein

  • Description modified (diff)

comment:114 Changed 5 months ago by jmantysalo

  • Cc jmantysalo added

comment:115 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:116 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:117 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:118 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:119 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:120 Changed 5 months ago by chapoton

  • Description modified (diff)

The top ten worse files in 8.5.b3 are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 31 doctests failed',
 'sage -t --long src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 'sage -t --long src/sage/numerical/mip.pyx  # 47 doctests failed',
 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'sage -t --long src/sage/rings/function_field/ideal.py  # 56 doctests failed',
 'sage -t --long src/sage/graphs/graph.py  # 58 doctests failed',
 'sage -t --long src/sage/graphs/connectivity.pyx  # 59 doctests failed',
 'sage -t --long src/sage/rings/tate_algebra_element.pyx  # 63 doctests failed',
 'sage -t --long src/sage/misc/explain_pickle.py  # 70 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 115 doctests failed']

comment:121 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:122 Changed 5 months ago by vklein

  • Description modified (diff)

comment:123 Changed 5 months ago by vklein

  • Description modified (diff)

comment:124 Changed 5 months ago by chapoton

  • Description modified (diff)

Top ten worst files in 8.5.b4 are:

src/sage/graphs/graph.py  # 30 doctests failed
src/sage/numerical/linear_functions.pyx  # 30 doctests failed
src/sage/combinat/finite_state_machine.py  # 31 doctests failed
src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed
src/sage/numerical/mip.pyx  # 47 doctests failed
src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed
src/sage/graphs/connectivity.pyx  # 50 doctests failed
src/sage/rings/function_field/ideal.py  # 56 doctests failed
src/sage/misc/explain_pickle.py  # 70 doctests failed
src/sage/graphs/generic_graph.py  # 77 doctests failed

comment:125 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:126 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:127 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:128 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:129 Changed 5 months ago by vklein

  • Description modified (diff)

comment:130 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:131 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:132 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:133 Changed 5 months ago by chapoton

Number of failing doctests in 8.5.beta4 by components

'en': 56, 'coding': 28, 'data_structures': 5, 'symbolic': 24, 'libs': 34,
 'schemes': 102, 'combinat': 292, 'dynamics': 39, 'interacts': 6, 'homology': 29,
 'plot': 5, 'functions': 5, 'matrix': 16, 'rings': 209, 'categories': 34,
 'docbuild': 2, 'algebras': 21, 'common': 1, 'calculus': 5, 'tests': 40,
 'matroids': 75, 'misc': 172, 'interfaces': 1, 'numerical': 206, 'modular': 82,
 'repl': 13, 'groups': 14, 'sandpiles': 22, 'game_theory': 11, 'structure': 6,
 'cpython': 7, 'sets': 6, 'geometry': 32, 'modules': 3, 'crypto': 13,
 'graphs': 292, 'ext': 8, 'doctest': 8, 'databases': 16

comment:134 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:135 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:136 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:137 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:138 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:139 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:140 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:141 Changed 5 months ago by chapoton

Worst 15 files in 8.5.b5:

[' src/sage/homology/simplicial_complex.py  # 23 doctests failed',
 ' src/sage/numerical/linear_tensor_element.pyx  # 23 doctests failed',
 ' src/sage/matroids/matroid.pyx  # 24 doctests failed',
 ' src/sage/rings/integer.pyx  # 24 doctests failed',
 ' src/sage/misc/decorators.py  # 28 doctests failed',
 ' src/sage/numerical/linear_tensor_constraints.py  # 28 doctests failed',
 ' src/sage/combinat/rigged_configurations/kr_tableaux.py  # 30 doctests failed',
 ' src/sage/graphs/graph.py  # 30 doctests failed',
 ' src/sage/numerical/linear_functions.pyx  # 30 doctests failed',
 ' src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 ' src/sage/numerical/mip.pyx  # 47 doctests failed',
 ' src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 ' src/sage/graphs/connectivity.pyx  # 49 doctests failed',
 ' src/sage/misc/explain_pickle.py  # 70 doctests failed',
 ' src/sage/graphs/generic_graph.py  # 79 doctests failed']

comment:142 Changed 5 months ago by chapoton

  • Description modified (diff)

and by components:

[('common', 1), ('interfaces', 1), ('docbuild', 2), ('coding', 2), ('modules', 4), 
('functions', 5), ('calculus', 5), ('plot', 5), ('data_structures', 5), ('structure',
 6), ('interacts', 6), ('sets', 6), ('cpython', 7), ('doctest', 8), ('ext', 8), 
('crypto', 13), ('geometry', 13), ('repl', 13), ('groups', 15), ('algebras', 16),
 ('matrix', 17), ('sandpiles', 22), ('symbolic', 26), ('homology', 30), ('libs', 34),
 ('categories', 35), ('tests', 40), ('dynamics', 40), ('en', 56), ('matroids', 73),
 ('schemes', 80), ('modular', 82), ('rings', 141), ('misc', 171), ('numerical', 206), 
('combinat', 240), ('graphs', 300)]
Last edited 5 months ago by chapoton (previous) (diff)

comment:143 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:144 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:145 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:146 Changed 5 months ago by vklein

  • Description modified (diff)

comment:147 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:148 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:149 Changed 5 months ago by chapoton

worst 20 files in 8.5.b6:

['/sage/matroids/matroid.pyx  # 18 doctests failed',
 '/sage/combinat/finite_state_machine.py  # 20 doctests failed',
 '/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 '/sage/numerical/linear_tensor.py  # 20 doctests failed',
 '/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 '/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 '/sage/homology/simplicial_complex.py  # 22 doctests failed',
 '/sage/sandpiles/sandpile.py  # 22 doctests failed',
 '/sage/numerical/linear_tensor_element.pyx  # 23 doctests failed',
 '/sage/rings/integer.pyx  # 24 doctests failed',
 '/sage/misc/decorators.py  # 28 doctests failed',
 '/sage/numerical/linear_tensor_constraints.py  # 28 doctests failed',
 '/sage/graphs/graph.py  # 30 doctests failed',
 '/sage/numerical/linear_functions.pyx  # 30 doctests failed',
 '/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 '/sage/numerical/mip.pyx  # 47 doctests failed',
 '/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 '/sage/graphs/connectivity.pyx  # 49 doctests failed',
 '/sage/misc/explain_pickle.py  # 70 doctests failed',
 '/sage/graphs/generic_graph.py  # 78 doctests failed']

comment:150 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:151 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:152 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:153 Changed 5 months ago by chapoton

  • Description modified (diff)

comment:154 Changed 5 months ago by vklein

  • Description modified (diff)
Note: See TracTickets for help on using tickets.