Opened 3 years ago
Last modified 21 months ago
#26212 closed task
py3: make all tests pass — at Version 131
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | python3 | Keywords: | |
Cc: | vklein, embray, jmantysalo, gh-timokau | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This ticket is used to keep track of the progress towards python3.
release | files having failing doctests | more than 100 | from 10 to 100 | from 1 to 10 | failing doctests |
8.4.b3 | 915 | 42 | 251 | 622 | 17972 |
8.4.b4 | 803 | 23 | 175 | 605 | 10921 |
8.4.b5 | 657 | 17 | 145 | 495 | 8509 |
8.4.b6 | 594 | 17 | 127 | 450 | 7706 |
8.4.b7 | 587 | 17 | 128 | 442 | 7678 |
8.4.rc0 | 524 | 16 | 119 | 389 | 6976 |
8.5.b0 | 461 | 6 | 94 | 361 | 4206 |
8.5.b1 | 414 | 3 | 76 | 335 | 3206 |
8.5.b2 | 370 | 1 | 66 | 303 | 2465 |
8.5.b3 | 339 | 1 | 62 | 276 | 2245 |
8.5.b4 | 312 | 0 | 58 | 254 | 1947 |
Folders where all tests pass (8.5.b2):
- algebras/steenrod ✔ #26219 and #26220
- arith #26208 ✔
- combinat/sf (#26220 +) #26215
- combinat/words #26362, #26458, #26473, #26590
- docs ✔ #26310
- features ✔
- finance #26213 ✔
- games ✔
- gsl
- groups/matrix_gps #26400 ✔
- groups/lie_gps #26518
- knots ✔
- lfunctions ✔
- logic #26214 ✔
- manifolds #26475
- media ✔
- monoids ✔ #26294
- parallel ✔
- probability #26216 ✔
- quadratic_forms/ #26224 ✔
- quivers #26211 ✔
- rings/asymptotic #26146
- rings/number_field #26263
- sat #26543 ✔
- schemes/toric #26664
- server ✔
- stats #26401 ✔
- tensor #26295, #26601
- typeset ✔
Folders with work in progress:
- algebras #26316 #26399 #26279 #26646 #26688
- categories #26545
- coding #26026
- combinat/species #26328, #26610
- combinat/finite_state_machine #26147, #26468, #26737
- combinat/root_system #26649
- combinat/subset #26510
- combinat #26535 #26671 #26719
- crypto #26398
- data_structures #24852
- database #26702 #26704
- doc/en #26346
- functions #24758, #26591
- game_theory #26429 #26738 (final)
- geometry #26726
- graphs #26431 #26447 #26527 #26640 #26645
- interfaces #26314
- libs #24804 #26665
- matrix/ #26236 #26716
- misc #26312, #26390 #26674 #26720
- modular #26382, #26611
- modular/modsym #26673
- modules #26276
- numerical/backends #24740 (for
char *
arguments management) and #24741, #26631 - plot #26210 (partial fix only) #26299 #26301 #26321
- rings #26697
- rings (power series) #26539
- rings/function_field #26721
- rings/polynomial #26670
- rings/number_field #26619
- sandpiles #26016 #26628 #26722
- sets #26659
- schemes/elliptic_curves #26536, #26529, #26570, #26594
- structure #25694
- tests/french_book #26495 #23572
Change History (132)
comment:1 Changed 3 years ago by
- Description modified (diff)
comment:2 Changed 3 years ago by
- Description modified (diff)
comment:3 Changed 3 years ago by
- Description modified (diff)
comment:4 Changed 3 years ago by
- Description modified (diff)
comment:5 Changed 3 years ago by
- Description modified (diff)
comment:6 Changed 3 years ago by
- Description modified (diff)
comment:7 Changed 3 years ago by
- Description modified (diff)
comment:8 Changed 3 years ago by
- Description modified (diff)
comment:9 Changed 3 years ago by
- Description modified (diff)
comment:10 Changed 3 years ago by
- Description modified (diff)
comment:11 Changed 3 years ago by
- Description modified (diff)
comment:12 Changed 3 years ago by
- Description modified (diff)
comment:13 Changed 3 years ago by
- Description modified (diff)
comment:14 Changed 3 years ago by
- Description modified (diff)
comment:15 Changed 3 years ago by
- Cc vklein added
comment:16 Changed 3 years ago by
- Description modified (diff)
comment:17 Changed 3 years ago by
- Description modified (diff)
comment:18 Changed 3 years ago by
- Description modified (diff)
comment:19 Changed 3 years ago by
- Description modified (diff)
comment:20 Changed 3 years ago by
- Description modified (diff)
comment:21 Changed 3 years ago by
- Description modified (diff)
comment:22 Changed 3 years ago by
- Description modified (diff)
comment:23 Changed 3 years ago by
- Description modified (diff)
comment:24 Changed 3 years ago by
- Description modified (diff)
comment:25 Changed 3 years ago by
- Description modified (diff)
comment:26 Changed 3 years ago by
- Description modified (diff)
comment:27 Changed 3 years ago by
- Description modified (diff)
comment:28 Changed 3 years ago by
- Description modified (diff)
comment:29 Changed 3 years ago by
- Description modified (diff)
comment:30 Changed 3 years ago by
- Description modified (diff)
comment:31 Changed 3 years ago by
- Description modified (diff)
comment:32 Changed 3 years ago by
- Description modified (diff)
comment:33 Changed 3 years ago by
- Description modified (diff)
comment:34 Changed 3 years ago by
- Description modified (diff)
comment:35 Changed 3 years ago by
- Description modified (diff)
comment:36 Changed 3 years ago by
- Description modified (diff)
comment:37 Changed 3 years ago by
- Description modified (diff)
comment:38 Changed 3 years ago by
- Description modified (diff)
comment:39 Changed 3 years ago by
- Description modified (diff)
comment:40 Changed 3 years ago by
- Description modified (diff)
comment:41 Changed 3 years ago by
- Description modified (diff)
comment:42 Changed 3 years ago by
- Description modified (diff)
comment:43 Changed 3 years ago by
- Description modified (diff)
comment:44 Changed 3 years ago by
- Description modified (diff)
comment:45 Changed 3 years ago by
- Description modified (diff)
comment:46 Changed 3 years ago by
- Description modified (diff)
comment:47 Changed 3 years ago by
- Description modified (diff)
comment:48 Changed 3 years ago by
- Description modified (diff)
comment:49 Changed 3 years ago by
- Description modified (diff)
comment:50 Changed 3 years ago by
- Description modified (diff)
comment:51 Changed 3 years ago by
- Description modified (diff)
comment:52 Changed 3 years ago by
- Description modified (diff)
comment:53 Changed 3 years ago by
- Description modified (diff)
comment:54 Changed 3 years ago by
- Description modified (diff)
comment:55 Changed 3 years ago by
- Description modified (diff)
comment:56 Changed 3 years ago by
- Description modified (diff)
comment:57 Changed 3 years ago by
- Description modified (diff)
comment:58 Changed 3 years ago by
- Description modified (diff)
comment:59 Changed 3 years ago by
- Description modified (diff)
comment:60 Changed 3 years ago by
- Description modified (diff)
comment:61 Changed 3 years ago by
- Description modified (diff)
comment:62 Changed 3 years ago by
- Description modified (diff)
comment:63 Changed 3 years ago by
- Description modified (diff)
comment:64 Changed 3 years ago by
- Description modified (diff)
comment:65 Changed 3 years ago by
- Description modified (diff)
comment:66 Changed 3 years ago by
- Description modified (diff)
comment:67 Changed 3 years ago by
- Description modified (diff)
comment:68 Changed 3 years ago by
- Cc embray added
comment:69 Changed 3 years ago by
- Description modified (diff)
comment:70 Changed 3 years ago by
- Description modified (diff)
comment:71 Changed 3 years ago by
- Description modified (diff)
comment:72 Changed 3 years ago by
- Description modified (diff)
comment:73 Changed 3 years ago by
- Description modified (diff)
comment:75 Changed 3 years ago by
- Description modified (diff)
comment:76 Changed 3 years ago by
- Description modified (diff)
comment:77 Changed 3 years ago by
The six remaining files with many failures are
['sage -t --long src/sage/combinat/finite_state_machine.py # 189 doctests failed', 'sage -t --long src/sage/dynamics/arithmetic_dynamics/projective_ds.py # 105 doctests failed', 'sage -t --long src/sage/graphs/generic_graph.py # 110 doctests failed', 'sage -t --long src/sage/groups/lie_gps/nilpotent_lie_group.py # 143 doctests failed', 'sage -t --long src/sage/rings/padics/padic_lattice_element.py # 167 doctests failed', 'sage -t --long src/sage/rings/valuation/limit_valuation.py # 106 doctests failed']
comment:78 Changed 3 years ago by
- Description modified (diff)
comment:79 Changed 3 years ago by
- Description modified (diff)
comment:80 follow-up: ↓ 84 Changed 3 years ago by
For whoever wants to work on it, regarding
sage -t --long src/sage/combinat/finite_state_machine.py # 189 doctests failed
about 150 of the failures can be cured by replacing 'iteritems' by 'items' in lines like
elif hasattr(data, 'iteritems'): # data is a dict (or something similar),
I don't know if 'items' is the right attribute to check, or if it would actually be better to change to isinstance(data, dict)
. What other data structures are mean to be acceptable? What is "something similar" to a dict?
comment:81 Changed 3 years ago by
- Description modified (diff)
comment:82 Changed 3 years ago by
- Description modified (diff)
comment:83 Changed 3 years ago by
- Description modified (diff)
comment:84 in reply to: ↑ 80 Changed 3 years ago by
Replying to jhpalmieri:
For whoever wants to work on it, regarding ... I don't know if 'items' is the right attribute to check, or if it would actually be better to change to
isinstance(data, dict)
. What other data structures are mean to be acceptable? What is "something similar" to a dict?
There is some custom "Mapping types" in sage like FreeModuleElement_generic_sparse
, which implements items
and iteritems
but doesn't inherit from dict
.
comment:85 Changed 3 years ago by
- Description modified (diff)
comment:86 Changed 3 years ago by
- Description modified (diff)
comment:87 Changed 3 years ago by
- Description modified (diff)
comment:88 Changed 3 years ago by
- Description modified (diff)
comment:89 Changed 3 years ago by
- Description modified (diff)
comment:90 Changed 3 years ago by
- Description modified (diff)
comment:91 Changed 3 years ago by
- Description modified (diff)
comment:92 Changed 3 years ago by
- Description modified (diff)
comment:93 Changed 3 years ago by
There was a regression in the manifolds folder (sigh)..
The 3 remaining files with more than 100 failing doctests are
['sage -t --long src/sage/combinat/finite_state_machine.py # 182 doctests failed', 'sage -t --long src/sage/graphs/generic_graph.py # 109 doctests failed', 'sage -t --long src/sage/rings/padics/padic_lattice_element.py # 167 doctests failed']
The first one is already tackled in #26147 at least partially.
comment:94 Changed 3 years ago by
- Description modified (diff)
comment:95 Changed 3 years ago by
Regarding
'sage -t --long src/sage/rings/padics/padic_lattice_element.py # 167 doctests failed'
I can reproduce those failures when I run ./sage -t ...
, but (at least for the first few) not when I run Sage interactively. Odd.
comment:96 Changed 3 years ago by
- Description modified (diff)
comment:97 Changed 3 years ago by
- Description modified (diff)
comment:98 Changed 3 years ago by
- Description modified (diff)
comment:99 Changed 3 years ago by
- Description modified (diff)
comment:100 Changed 3 years ago by
- Description modified (diff)
comment:101 Changed 3 years ago by
- Description modified (diff)
comment:102 Changed 3 years ago by
- Description modified (diff)
Top ten bad files in 8.5.b2 are
['sage -t --long src/sage/numerical/backends/cvxopt_sdp_backend.pyx # 39 doctests failed', 'sage -t --long src/sage/algebras/iwahori_hecke_algebra.py # 40 doctests failed', 'sage -t --long src/sage/numerical/mip.pyx # 47 doctests failed', 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst # 49 doctests failed', 'sage -t --long src/sage/rings/function_field/ideal.py # 56 doctests failed', 'sage -t --long src/sage/graphs/graph.py # 59 doctests failed', 'sage -t --long src/sage/graphs/connectivity.pyx # 60 doctests failed', 'sage -t --long src/sage/misc/explain_pickle.py # 70 doctests failed', 'sage -t --long src/sage/numerical/sdp.pyx # 75 doctests failed', 'sage -t --long src/sage/graphs/generic_graph.py # 109 doctests failed']
comment:103 Changed 3 years ago by
- Description modified (diff)
comment:104 Changed 3 years ago by
- Description modified (diff)
comment:105 Changed 3 years ago by
- Description modified (diff)
comment:106 Changed 3 years ago by
- Description modified (diff)
comment:107 Changed 3 years ago by
- Description modified (diff)
comment:108 Changed 3 years ago by
- Description modified (diff)
comment:109 Changed 3 years ago by
- Description modified (diff)
comment:110 Changed 3 years ago by
- Description modified (diff)
comment:111 Changed 3 years ago by
- Description modified (diff)
comment:112 Changed 3 years ago by
- Milestone changed from sage-8.4 to sage-8.5
comment:113 Changed 3 years ago by
- Description modified (diff)
comment:114 Changed 3 years ago by
- Cc jmantysalo added
comment:115 Changed 3 years ago by
- Description modified (diff)
comment:116 Changed 3 years ago by
- Description modified (diff)
comment:117 Changed 3 years ago by
- Description modified (diff)
comment:118 Changed 3 years ago by
- Description modified (diff)
comment:119 Changed 3 years ago by
- Description modified (diff)
comment:120 Changed 3 years ago by
- Description modified (diff)
The top ten worse files in 8.5.b3 are
['sage -t --long src/sage/combinat/finite_state_machine.py # 31 doctests failed', 'sage -t --long src/sage/schemes/riemann_surfaces/riemann_surface.py # 36 doctests failed', 'sage -t --long src/sage/numerical/mip.pyx # 47 doctests failed', 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst # 49 doctests failed', 'sage -t --long src/sage/rings/function_field/ideal.py # 56 doctests failed', 'sage -t --long src/sage/graphs/graph.py # 58 doctests failed', 'sage -t --long src/sage/graphs/connectivity.pyx # 59 doctests failed', 'sage -t --long src/sage/rings/tate_algebra_element.pyx # 63 doctests failed', 'sage -t --long src/sage/misc/explain_pickle.py # 70 doctests failed', 'sage -t --long src/sage/graphs/generic_graph.py # 115 doctests failed']
comment:121 Changed 3 years ago by
- Description modified (diff)
comment:122 Changed 3 years ago by
- Description modified (diff)
comment:123 Changed 3 years ago by
- Description modified (diff)
comment:124 Changed 3 years ago by
- Description modified (diff)
Top ten worst files in 8.5.b4 are:
src/sage/graphs/graph.py # 30 doctests failed src/sage/numerical/linear_functions.pyx # 30 doctests failed src/sage/combinat/finite_state_machine.py # 31 doctests failed src/sage/schemes/riemann_surfaces/riemann_surface.py # 36 doctests failed src/sage/numerical/mip.pyx # 47 doctests failed src/doc/en/thematic_tutorials/sandpile.rst # 49 doctests failed src/sage/graphs/connectivity.pyx # 50 doctests failed src/sage/rings/function_field/ideal.py # 56 doctests failed src/sage/misc/explain_pickle.py # 70 doctests failed src/sage/graphs/generic_graph.py # 77 doctests failed
comment:125 Changed 3 years ago by
- Description modified (diff)
comment:126 Changed 3 years ago by
- Description modified (diff)
comment:127 Changed 3 years ago by
- Description modified (diff)
comment:128 Changed 3 years ago by
- Description modified (diff)
comment:129 Changed 3 years ago by
- Description modified (diff)
comment:130 Changed 3 years ago by
- Description modified (diff)
comment:131 Changed 3 years ago by
- Description modified (diff)
Hadn't even seen this ticket; very nice.