Opened 13 months ago

Last modified 5 weeks ago

#26212 new task

py3: make all tests pass — at Version 117

Reported by: chapoton Owned by:
Priority: major Milestone:
Component: python3 Keywords:
Cc: vklein, embray, jmantysalo, gh-timokau Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

This ticket is used to keep track of the progress towards python3.

release files having failing doctests more than 100 from 10 to 100 from 1 to 10 failing doctests
8.4.b3 915 42 251 622 17972
8.4.b4 803 23 175 605 10921
8.4.b5 657 17 145 495 8509
8.4.b6 594 17 127 450 7706
8.4.b7 587 17 128 442 7678
8.4.rc0 524 16 119 389 6976
8.5.b0 461 6 94 361 4206
8.5.b1 414 3 76 335 3206
8.5.b2 370 1 66 303 2465

Folders where all tests pass (8.5.b2):

Folders with work in progress:

Change History (118)

comment:1 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:2 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:3 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:4 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:5 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:6 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:7 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:8 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:9 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:10 Changed 13 months ago by jhpalmieri

  • Description modified (diff)

comment:11 Changed 13 months ago by jhpalmieri

  • Description modified (diff)

comment:12 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:13 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:14 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:15 Changed 13 months ago by vklein

  • Cc vklein added

comment:16 Changed 13 months ago by vklein

  • Description modified (diff)

comment:17 Changed 13 months ago by vklein

  • Description modified (diff)

comment:18 Changed 13 months ago by vklein

  • Description modified (diff)

comment:19 Changed 13 months ago by vklein

  • Description modified (diff)

comment:20 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:21 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:22 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:23 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:24 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:25 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:26 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:27 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:28 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:29 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:30 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:31 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:32 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:33 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:34 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:35 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:36 Changed 13 months ago by vklein

  • Description modified (diff)

comment:37 Changed 13 months ago by vklein

  • Description modified (diff)

comment:38 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:39 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:40 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:41 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:42 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:43 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:44 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:45 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:46 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:47 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:48 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:49 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:50 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:51 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:52 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:53 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:54 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:55 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:56 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:57 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:58 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:59 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:60 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:61 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:62 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:63 Changed 13 months ago by chapoton

  • Description modified (diff)

comment:64 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:65 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:66 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:67 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:68 Changed 12 months ago by embray

  • Cc embray added

Hadn't even seen this ticket; very nice.

comment:69 Changed 12 months ago by vklein

  • Description modified (diff)

comment:70 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:71 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:72 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:73 Changed 12 months ago by vklein

  • Description modified (diff)

comment:74 Changed 12 months ago by chapoton

  • Description modified (diff)

good progress on 8.5.b0

comment:75 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:76 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:77 Changed 12 months ago by chapoton

The six remaining files with many failures are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 189 doctests failed',
 'sage -t --long src/sage/dynamics/arithmetic_dynamics/projective_ds.py  # 105 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 110 doctests failed',
 'sage -t --long src/sage/groups/lie_gps/nilpotent_lie_group.py  # 143 doctests failed',
 'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed',
 'sage -t --long src/sage/rings/valuation/limit_valuation.py  # 106 doctests failed']

comment:78 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:79 Changed 12 months ago by jhpalmieri

  • Description modified (diff)

comment:80 follow-up: Changed 12 months ago by jhpalmieri

For whoever wants to work on it, regarding

sage -t --long src/sage/combinat/finite_state_machine.py  # 189 doctests failed

about 150 of the failures can be cured by replacing 'iteritems' by 'items' in lines like

        elif hasattr(data, 'iteritems'):
            # data is a dict (or something similar),

I don't know if 'items' is the right attribute to check, or if it would actually be better to change to isinstance(data, dict). What other data structures are mean to be acceptable? What is "something similar" to a dict?

comment:81 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:82 Changed 12 months ago by vklein

  • Description modified (diff)

comment:83 Changed 12 months ago by vklein

  • Description modified (diff)

comment:84 in reply to: ↑ 80 Changed 12 months ago by vklein

Replying to jhpalmieri:

For whoever wants to work on it, regarding ... I don't know if 'items' is the right attribute to check, or if it would actually be better to change to isinstance(data, dict). What other data structures are mean to be acceptable? What is "something similar" to a dict?

There is some custom "Mapping types" in sage like FreeModuleElement_generic_sparse, which implements items and iteritems but doesn't inherit from dict.

Changed 12 months ago by chapoton

tool to extract the data from patchbot log

comment:85 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:86 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:87 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:88 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:89 Changed 12 months ago by vklein

  • Description modified (diff)

comment:90 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:91 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:92 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:93 Changed 12 months ago by chapoton

There was a regression in the manifolds folder (sigh)..

The 3 remaining files with more than 100 failing doctests are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 182 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 109 doctests failed',
 'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed']

The first one is already tackled in #26147 at least partially.

comment:94 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:95 Changed 12 months ago by jhpalmieri

Regarding

'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed'

I can reproduce those failures when I run ./sage -t ..., but (at least for the first few) not when I run Sage interactively. Odd.

comment:96 Changed 12 months ago by slabbe

  • Description modified (diff)

comment:97 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:98 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:99 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:100 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:101 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:102 Changed 12 months ago by chapoton

  • Description modified (diff)

Top ten bad files in 8.5.b2 are

['sage -t --long src/sage/numerical/backends/cvxopt_sdp_backend.pyx  # 39 doctests failed',
 'sage -t --long src/sage/algebras/iwahori_hecke_algebra.py  # 40 doctests failed',
 'sage -t --long src/sage/numerical/mip.pyx  # 47 doctests failed',
 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'sage -t --long src/sage/rings/function_field/ideal.py  # 56 doctests failed',
 'sage -t --long src/sage/graphs/graph.py  # 59 doctests failed',
 'sage -t --long src/sage/graphs/connectivity.pyx  # 60 doctests failed',
 'sage -t --long src/sage/misc/explain_pickle.py  # 70 doctests failed',
 'sage -t --long src/sage/numerical/sdp.pyx  # 75 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 109 doctests failed']

comment:103 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:104 Changed 12 months ago by chapoton

  • Description modified (diff)

comment:105 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:106 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:107 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:108 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:109 Changed 11 months ago by vklein

  • Description modified (diff)

comment:110 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:111 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:112 Changed 11 months ago by chapoton

  • Milestone changed from sage-8.4 to sage-8.5

comment:113 Changed 11 months ago by vklein

  • Description modified (diff)

comment:114 Changed 11 months ago by jmantysalo

  • Cc jmantysalo added

comment:115 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:116 Changed 11 months ago by chapoton

  • Description modified (diff)

comment:117 Changed 11 months ago by chapoton

  • Description modified (diff)
Note: See TracTickets for help on using tickets.