Opened 4 years ago

Closed 3 years ago

#26212 closed task (worksforme)

py3: make all tests pass

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords:
Cc: vklein, Erik Bray, Jori Mäntysalo, Timo Kaufmann Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Frédéric Chapoton)

This ticket is used to keep track of the progress towards python3.

As this ticket is too long, final steps are moved to #28298

release files having failing doctests more than 100 from 10 to 100 from 1 to 10 failing doctests
8.4.b3 915 42 251 622 17972
8.4.b4 803 23 175 605 10921
8.4.b5 657 17 145 495 8509
8.4.b6 594 17 127 450 7706
8.4.b7 587 17 128 442 7678
8.4.rc0 524 16 119 389 6976
8.5.b0 461 6 94 361 4206
8.5.b1 414 3 76 335 3206
8.5.b2 370 1 66 303 2465
8.5.b3 339 1 62 276 2245
8.5.b4 312 0 58 254 1947
8.5.b5 295 0 51 244 1741
8.5.b6 264 0 43 221 1514
8.5.rc0 252 0 39 213 1393
8.6.b0 234 0 30 204 1163
8.6.b1 231 0 30 201 1146
8.6.rc0 232 0 28 204 1124
8.6.rc1 236 0 30 206 1136
8.7.b0 240 1 38 201 1605
8.7.b1 200 0 23 177 866
8.7.b2 198 0 24 174 863
8.7.b3 166 0 20 146 717
8.7.b4 165 0 19 146 703
8.7.b5 143 0 12 131 562
8.7.b6 137 0 8 129 464
8.7.b7 122 0 8 114 447
8.7.rc0 105 0 7 98 384
8.8.b0 102 0 7 95 370

Now with python 3.7.3:

release files having failing doctests more than 100 from 10 to 100 from 1 to 10 failing doctests
8.8.b1 105 0 6 99 382
8.8.b2 94 0 6 88 324
8.8.b3 82 0 6 76 282
8.8.b4 77 0 2 75 246
8.8.b5 56 0 2 54 173
8.8.b6 49 0 1 48 151
8.8.b7 44 0 1 43 136
8.8.rc0 32 0 0 32 92
8.9.b0 22 0 0 22 71
8.9.b2 18 0 0 18 58
8.9.b3 15 0 0 15 47
8.9.b4 12 0 0 12 33
8.9.b5 8 0 0 8 18
8.9.b7 5 0 0 5 15
8.9.b9 4 0 0 4 14
8.9.rc0 3 0 0 3 7

Folders where all tests pass

Fragile folders (still fails on the reference machine)

These doctests pass when run on each file alone.

  • repl #26881
    ┗ /attach.py  # 4
    
  • FLINT issue in src/sage/rings/polynomial/polynomial_rational_flint.pyx

Folders with work in progress

Attachments (1)

extraction.py (1.2 KB) - added by Frédéric Chapoton 4 years ago.
tool to extract the data from patchbot log

Download all attachments as: .zip

Change History (410)

comment:1 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:2 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:3 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:4 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:5 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:6 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:7 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:8 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:9 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:10 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:11 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:12 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:13 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:14 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:15 Changed 4 years ago by vklein

Cc: vklein added

comment:16 Changed 4 years ago by vklein

Description: modified (diff)

comment:17 Changed 4 years ago by vklein

Description: modified (diff)

comment:18 Changed 4 years ago by vklein

Description: modified (diff)

comment:19 Changed 4 years ago by vklein

Description: modified (diff)

comment:20 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:21 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:22 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:23 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:24 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:25 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:26 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:27 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:28 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:29 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:30 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:31 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:32 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:33 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:34 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:35 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:36 Changed 4 years ago by vklein

Description: modified (diff)

comment:37 Changed 4 years ago by vklein

Description: modified (diff)

comment:38 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:39 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:40 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:41 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:42 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:43 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:44 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:45 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:46 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:47 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:48 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:49 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:50 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:51 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:52 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:53 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:54 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:55 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:56 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:57 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:58 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:59 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:60 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:61 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:62 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:63 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:64 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:65 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:66 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:67 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:68 Changed 4 years ago by Erik Bray

Cc: Erik Bray added

Hadn't even seen this ticket; very nice.

comment:69 Changed 4 years ago by vklein

Description: modified (diff)

comment:70 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:71 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:72 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:73 Changed 4 years ago by vklein

Description: modified (diff)

comment:74 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

good progress on 8.5.b0

comment:75 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:76 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:77 Changed 4 years ago by Frédéric Chapoton

The six remaining files with many failures are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 189 doctests failed',
 'sage -t --long src/sage/dynamics/arithmetic_dynamics/projective_ds.py  # 105 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 110 doctests failed',
 'sage -t --long src/sage/groups/lie_gps/nilpotent_lie_group.py  # 143 doctests failed',
 'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed',
 'sage -t --long src/sage/rings/valuation/limit_valuation.py  # 106 doctests failed']

comment:78 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:79 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:80 Changed 4 years ago by John Palmieri

For whoever wants to work on it, regarding

sage -t --long src/sage/combinat/finite_state_machine.py  # 189 doctests failed

about 150 of the failures can be cured by replacing 'iteritems' by 'items' in lines like

        elif hasattr(data, 'iteritems'):
            # data is a dict (or something similar),

I don't know if 'items' is the right attribute to check, or if it would actually be better to change to isinstance(data, dict). What other data structures are mean to be acceptable? What is "something similar" to a dict?

comment:81 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:82 Changed 4 years ago by vklein

Description: modified (diff)

comment:83 Changed 4 years ago by vklein

Description: modified (diff)

comment:84 in reply to:  80 Changed 4 years ago by vklein

Replying to jhpalmieri:

For whoever wants to work on it, regarding ... I don't know if 'items' is the right attribute to check, or if it would actually be better to change to isinstance(data, dict). What other data structures are mean to be acceptable? What is "something similar" to a dict?

There is some custom "Mapping types" in sage like FreeModuleElement_generic_sparse, which implements items and iteritems but doesn't inherit from dict.

Changed 4 years ago by Frédéric Chapoton

Attachment: extraction.py added

tool to extract the data from patchbot log

comment:85 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:86 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:87 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:88 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:89 Changed 4 years ago by vklein

Description: modified (diff)

comment:90 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:91 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:92 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:93 Changed 4 years ago by Frédéric Chapoton

There was a regression in the manifolds folder (sigh)..

The 3 remaining files with more than 100 failing doctests are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 182 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 109 doctests failed',
 'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed']

The first one is already tackled in #26147 at least partially.

comment:94 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:95 Changed 4 years ago by John Palmieri

Regarding

'sage -t --long src/sage/rings/padics/padic_lattice_element.py  # 167 doctests failed'

I can reproduce those failures when I run ./sage -t ..., but (at least for the first few) not when I run Sage interactively. Odd.

comment:96 Changed 4 years ago by Sébastien Labbé

Description: modified (diff)

comment:97 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:98 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:99 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:100 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:101 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:102 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

Top ten bad files in 8.5.b2 are

['sage -t --long src/sage/numerical/backends/cvxopt_sdp_backend.pyx  # 39 doctests failed',
 'sage -t --long src/sage/algebras/iwahori_hecke_algebra.py  # 40 doctests failed',
 'sage -t --long src/sage/numerical/mip.pyx  # 47 doctests failed',
 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'sage -t --long src/sage/rings/function_field/ideal.py  # 56 doctests failed',
 'sage -t --long src/sage/graphs/graph.py  # 59 doctests failed',
 'sage -t --long src/sage/graphs/connectivity.pyx  # 60 doctests failed',
 'sage -t --long src/sage/misc/explain_pickle.py  # 70 doctests failed',
 'sage -t --long src/sage/numerical/sdp.pyx  # 75 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 109 doctests failed']

comment:103 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:104 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:105 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:106 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:107 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:108 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:109 Changed 4 years ago by vklein

Description: modified (diff)

comment:110 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:111 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:112 Changed 4 years ago by Frédéric Chapoton

Milestone: sage-8.4sage-8.5

comment:113 Changed 4 years ago by vklein

Description: modified (diff)

comment:114 Changed 4 years ago by Jori Mäntysalo

Cc: Jori Mäntysalo added

comment:115 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:116 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:117 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:118 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:119 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:120 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

The top ten worse files in 8.5.b3 are

['sage -t --long src/sage/combinat/finite_state_machine.py  # 31 doctests failed',
 'sage -t --long src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 'sage -t --long src/sage/numerical/mip.pyx  # 47 doctests failed',
 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'sage -t --long src/sage/rings/function_field/ideal.py  # 56 doctests failed',
 'sage -t --long src/sage/graphs/graph.py  # 58 doctests failed',
 'sage -t --long src/sage/graphs/connectivity.pyx  # 59 doctests failed',
 'sage -t --long src/sage/rings/tate_algebra_element.pyx  # 63 doctests failed',
 'sage -t --long src/sage/misc/explain_pickle.py  # 70 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 115 doctests failed']

comment:121 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:122 Changed 4 years ago by vklein

Description: modified (diff)

comment:123 Changed 4 years ago by vklein

Description: modified (diff)

comment:124 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

Top ten worst files in 8.5.b4 are:

src/sage/graphs/graph.py  # 30 doctests failed
src/sage/numerical/linear_functions.pyx  # 30 doctests failed
src/sage/combinat/finite_state_machine.py  # 31 doctests failed
src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed
src/sage/numerical/mip.pyx  # 47 doctests failed
src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed
src/sage/graphs/connectivity.pyx  # 50 doctests failed
src/sage/rings/function_field/ideal.py  # 56 doctests failed
src/sage/misc/explain_pickle.py  # 70 doctests failed
src/sage/graphs/generic_graph.py  # 77 doctests failed

comment:125 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:126 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:127 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:128 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:129 Changed 4 years ago by vklein

Description: modified (diff)

comment:130 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:131 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:132 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:133 Changed 4 years ago by Frédéric Chapoton

Number of failing doctests in 8.5.beta4 by components

'en': 56, 'coding': 28, 'data_structures': 5, 'symbolic': 24, 'libs': 34,
 'schemes': 102, 'combinat': 292, 'dynamics': 39, 'interacts': 6, 'homology': 29,
 'plot': 5, 'functions': 5, 'matrix': 16, 'rings': 209, 'categories': 34,
 'docbuild': 2, 'algebras': 21, 'common': 1, 'calculus': 5, 'tests': 40,
 'matroids': 75, 'misc': 172, 'interfaces': 1, 'numerical': 206, 'modular': 82,
 'repl': 13, 'groups': 14, 'sandpiles': 22, 'game_theory': 11, 'structure': 6,
 'cpython': 7, 'sets': 6, 'geometry': 32, 'modules': 3, 'crypto': 13,
 'graphs': 292, 'ext': 8, 'doctest': 8, 'databases': 16

comment:134 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:135 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:136 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:137 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:138 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:139 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:140 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:141 Changed 4 years ago by Frédéric Chapoton

Worst 15 files in 8.5.b5:

[' src/sage/homology/simplicial_complex.py  # 23 doctests failed',
 ' src/sage/numerical/linear_tensor_element.pyx  # 23 doctests failed',
 ' src/sage/matroids/matroid.pyx  # 24 doctests failed',
 ' src/sage/rings/integer.pyx  # 24 doctests failed',
 ' src/sage/misc/decorators.py  # 28 doctests failed',
 ' src/sage/numerical/linear_tensor_constraints.py  # 28 doctests failed',
 ' src/sage/combinat/rigged_configurations/kr_tableaux.py  # 30 doctests failed',
 ' src/sage/graphs/graph.py  # 30 doctests failed',
 ' src/sage/numerical/linear_functions.pyx  # 30 doctests failed',
 ' src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 ' src/sage/numerical/mip.pyx  # 47 doctests failed',
 ' src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 ' src/sage/graphs/connectivity.pyx  # 49 doctests failed',
 ' src/sage/misc/explain_pickle.py  # 70 doctests failed',
 ' src/sage/graphs/generic_graph.py  # 79 doctests failed']

comment:142 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

and by components:

[('common', 1), ('interfaces', 1), ('docbuild', 2), ('coding', 2), ('modules', 4), 
('functions', 5), ('calculus', 5), ('plot', 5), ('data_structures', 5), ('structure',
 6), ('interacts', 6), ('sets', 6), ('cpython', 7), ('doctest', 8), ('ext', 8), 
('crypto', 13), ('geometry', 13), ('repl', 13), ('groups', 15), ('algebras', 16),
 ('matrix', 17), ('sandpiles', 22), ('symbolic', 26), ('homology', 30), ('libs', 34),
 ('categories', 35), ('tests', 40), ('dynamics', 40), ('en', 56), ('matroids', 73),
 ('schemes', 80), ('modular', 82), ('rings', 141), ('misc', 171), ('numerical', 206), 
('combinat', 240), ('graphs', 300)]
Last edited 4 years ago by Frédéric Chapoton (previous) (diff)

comment:143 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:144 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:145 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:146 Changed 4 years ago by vklein

Description: modified (diff)

comment:147 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:148 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:149 Changed 4 years ago by Frédéric Chapoton

worst 20 files in 8.5.b6:

['/sage/matroids/matroid.pyx  # 18 doctests failed',
 '/sage/combinat/finite_state_machine.py  # 20 doctests failed',
 '/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 '/sage/numerical/linear_tensor.py  # 20 doctests failed',
 '/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 '/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 '/sage/homology/simplicial_complex.py  # 22 doctests failed',
 '/sage/sandpiles/sandpile.py  # 22 doctests failed',
 '/sage/numerical/linear_tensor_element.pyx  # 23 doctests failed',
 '/sage/rings/integer.pyx  # 24 doctests failed',
 '/sage/misc/decorators.py  # 28 doctests failed',
 '/sage/numerical/linear_tensor_constraints.py  # 28 doctests failed',
 '/sage/graphs/graph.py  # 30 doctests failed',
 '/sage/numerical/linear_functions.pyx  # 30 doctests failed',
 '/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 '/sage/numerical/mip.pyx  # 47 doctests failed',
 '/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 '/sage/graphs/connectivity.pyx  # 49 doctests failed',
 '/sage/misc/explain_pickle.py  # 70 doctests failed',
 '/sage/graphs/generic_graph.py  # 78 doctests failed']

comment:150 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:151 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:152 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:153 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:154 Changed 4 years ago by vklein

Description: modified (diff)

comment:155 Changed 4 years ago by vklein

Description: modified (diff)

comment:156 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:157 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:158 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:159 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

15 worst offenders in 8.5.rc0:

['src/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 'src/sage/homology/simplicial_complex.py  # 22 doctests failed',
 'src/sage/sandpiles/sandpile.py  # 22 doctests failed',
 'src/sage/numerical/linear_tensor_element.pyx  # 23 doctests failed',
 'src/sage/misc/decorators.py  # 28 doctests failed',
 'src/sage/numerical/linear_tensor_constraints.py  # 28 doctests failed',
 'src/sage/graphs/graph.py  # 30 doctests failed',
 'src/sage/numerical/linear_functions.pyx  # 30 doctests failed',
 'src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 'src/sage/numerical/mip.pyx  # 47 doctests failed',
 'src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'src/sage/misc/explain_pickle.py  # 70 doctests failed',
 'src/sage/graphs/generic_graph.py  # 74 doctests failed']

comment:160 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:161 Changed 4 years ago by vklein

Description: modified (diff)

comment:162 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:163 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:164 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:165 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:166 Changed 4 years ago by Frédéric Chapoton

15 worst offenders in 8.6.b0:

['src/sage/categories/finite_posets.py  # 15 doctests failed',
 'src/sage/combinat/matrices/hadamard_matrix.py  # 15 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 'src/sage/sandpiles/sandpile.py  # 22 doctests failed',
 'src/sage/matroids/matroid.pyx  # 23 doctests failed',
 'src/sage/homology/simplicial_complex.py  # 24 doctests failed',
 'src/sage/graphs/graph.py  # 28 doctests failed',
 'src/sage/misc/decorators.py  # 28 doctests failed',
 'src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 'src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'src/sage/graphs/generic_graph.py  # 68 doctests failed',
 'src/sage/misc/explain_pickle.py  # 70 doctests failed']
Last edited 4 years ago by Frédéric Chapoton (previous) (diff)

comment:167 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

maybe due to the upgrade of gap, there is a regression:

sage -t --long src/sage/groups/matrix_gps/finitely_generated.py
  # 3 doctests failed

comment:168 Changed 4 years ago by Timo Kaufmann

Cc: Timo Kaufmann added

comment:169 Changed 4 years ago by Frédéric Chapoton

Milestone: sage-8.5sage-8.7

comment:170 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:171 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:172 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:173 Changed 4 years ago by Frédéric Chapoton

worst 15 files in 8.6.b1:

['src/sage/categories/finite_posets.py  # 15 doctests failed',
 'src/sage/combinat/matrices/hadamard_matrix.py  # 15 doctests failed',
 'src/sage/matroids/matroid.pyx  # 17 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 'src/sage/sandpiles/sandpile.py  # 22 doctests failed',
 'src/sage/homology/simplicial_complex.py  # 23 doctests failed',
 'src/sage/graphs/graph.py  # 28 doctests failed',
 'src/sage/misc/decorators.py  # 28 doctests failed',
 'src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 'src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'src/sage/graphs/generic_graph.py  # 63 doctests failed',
 'src/sage/misc/explain_pickle.py  # 70 doctests failed']

comment:174 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:175 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:176 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:177 Changed 4 years ago by Frédéric Chapoton

files where failing doctests have re-appeared (regressions):

['src/sage/categories/crystals.py',
 'src/sage/matroids/circuit_closures_matroid.pyx',
 'src/sage/matroids/dual_matroid.py']

file where failing doctests have disappeared (progress):

['src/sage/misc/decorators.py',
 'src/sage/rings/polynomial/laurent_polynomial.pyx']

so this is a net loss of 1 file

comment:178 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:179 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:180 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:181 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

Getting worse again! Damn!

comment:182 Changed 4 years ago by Frédéric Chapoton

regressions in

 'sage -t --long src/sage/combinat/multiset_partition_into_sets_ordered.py',
 'sage -t --long src/sage/combinat/set_partition.py',
 'sage -t --long src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py',
 'sage -t --long src/sage/graphs/spanning_tree.pyx',
 'sage -t --long src/sage/modules/multi_filtered_vector_space.py',
 'sage -t --long src/sage/rings/invariants/invariant_theory.py'

and progress in

 'sage -t --long src/sage/matrix/compute_J_ideal.py',
 'sage -t --long src/sage/matroids/circuit_closures_matroid.pyx'}

so this a net loss of 4 files

comment:183 Changed 4 years ago by David Coudert

I don't have any doctest error with py3 for sage -t --long src/sage/graphs/spanning_tree.pyx. Can you share what you get. Thanks.

comment:184 Changed 4 years ago by Frédéric Chapoton

This and other failures can be seen in the unique patchbot report running python3 on ticket 0:

https://patchbot.sagemath.org/ticket/0/

sage -t --long src/sage/graphs/spanning_tree.pyx
**********************************************************************
File "src/sage/graphs/spanning_tree.pyx", line 188, in sage.graphs.spanning_tree.kruskal
Failed example:
    sorted(kruskal(G, check=True))
Expected:
    [('a', 'b', 4), ('a', 'h', 8), ('c', 'd', 7), ('c', 'f', 4), ('c', 'i', 2), ('d', 'e', 9), ('f', 'g', 2), ('g', 'h', 1)]
Got:
    [('a', 'b', 4),
     ('b', 'c', 8),
     ('c', 'd', 7),
     ('c', 'f', 4),
     ('c', 'i', 2),
     ('d', 'e', 9),
     ('f', 'g', 2),
     ('g', 'h', 1)]
**********************************************************************
1 item had failures:
   1 of  45 in sage.graphs.spanning_tree.kruskal
    [83 tests, 1 failure, 0.60 s]

comment:185 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:186 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:187 Changed 4 years ago by David Coudert

See #27059 for of fix of the issue of ​#comment:184

comment:188 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:189 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:190 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

massive regression in 8.7.beta0, in particular here:

sage -t --long src/sage/schemes/elliptic_curves/BSD.py # 17 doctests failed
sage -t --long src/sage/schemes/elliptic_curves/gal_reps.py  # 20 doctests failed
sage -t --long src/sage/schemes/elliptic_curves/isogeny_small_degree.py  # 72 doctests failed
sage -t --long src/sage/schemes/elliptic_curves/ell_curve_isogeny.py  # 204 doctests failed
Last edited 4 years ago by Frédéric Chapoton (previous) (diff)

comment:191 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:192 Changed 4 years ago by Frédéric Chapoton

Worst 15 files in 8.7.beta0 (once the large regression in isogenies is fixed):

 'sage -t --long src/sage/rings/polynomial/multi_polynomial_sequence.py  # 12 doctests failed',
 'sage -t --long src/sage/symbolic/constants.py  # 12 doctests failed',
 'sage -t --long src/sage/tests/french_book/mpoly.py  # 13 doctests failed',
 'sage -t --long src/sage/graphs/digraph.py  # 14 doctests failed',
 'sage -t --long src/sage/categories/finite_posets.py  # 15 doctests failed',
 'sage -t --long src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'sage -t --long src/sage/matroids/matroid.pyx  # 19 doctests failed',
 'sage -t --long src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'sage -t --long src/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 'sage -t --long src/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 'sage -t --long src/sage/sandpiles/sandpile.py  # 22 doctests failed',
 'sage -t --long src/sage/schemes/riemann_surfaces/riemann_surface.py  # 36 doctests failed',
 'sage -t --long src/doc/en/thematic_tutorials/sandpile.rst  # 49 doctests failed',
 'sage -t --long src/sage/graphs/generic_graph.py  # 51 doctests failed',
 'sage -t --long src/sage/misc/explain_pickle.py  # 70 doctests failed'

comment:193 Changed 4 years ago by vklein

Description: modified (diff)

comment:194 Changed 4 years ago by vklein

Description: modified (diff)

comment:195 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

good progress, no ? :-)

comment:196 Changed 4 years ago by Frédéric Chapoton

worst 15 files in 8.7.b1:

 'src/sage/matroids/graphic_matroid.py  # 11 doctests failed',
 'src/sage/schemes/product_projective/point.py  # 11 doctests failed',
 'src/sage/symbolic/expression.pyx  # 11 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_sequence.py  # 12 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/modular/modform/element.py  # 13 doctests failed',
 'src/sage/tests/french_book/mpoly.py  # 13 doctests failed',
 'src/sage/categories/finite_posets.py  # 15 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 20 doctests failed',
 'src/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed',
 'src/sage/graphs/generic_graph.py  # 50 doctests failed',
 'src/sage/misc/explain_pickle.py  # 70 doctests failed'

comment:197 Changed 4 years ago by Timo Kaufmann

That is some impressive progress! Good work.

comment:198 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)

comment:199 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)

comment:200 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)

comment:201 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:202 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:203 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:204 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:205 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:206 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

some progress again

comment:207 Changed 4 years ago by Frédéric Chapoton

Worst 15 files in 8.7.b3:

['src/sage/tests/french_book/programmation_doctest.py  # 10 doctests failed',
 'src/sage/matroids/graphic_matroid.py  # 11 doctests failed',
 'src/sage/schemes/product_projective/point.py  # 11 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_sequence.py  # 12 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/tests/french_book/mpoly.py  # 13 doctests failed',
 'src/sage/graphs/digraph.py  # 14 doctests failed',
 'src/sage/categories/finite_posets.py  # 15 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 'src/sage/graphs/generic_graph.py  # 30 doctests failed',
 'src/sage/misc/explain_pickle.py  # 70 doctests failed']

comment:208 Changed 4 years ago by vklein

Description: modified (diff)

comment:209 Changed 4 years ago by vklein

Description: modified (diff)

comment:210 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:211 Changed 4 years ago by Frédéric Chapoton

Worst 15 files in 8.7.b4:

'src/sage/symbolic/expression.pyx  # 10 doctests failed',
 'src/sage/matroids/graphic_matroid.py  # 11 doctests failed',
 'src/sage/schemes/product_projective/point.py  # 11 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_sequence.py  # 12 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/matrix/matrix_polynomial_dense.pyx  # 14 doctests failed',
 'src/sage/tests/books/computational-mathematics-with-sagemath/mpoly_doctest.py  # 14 doctests failed',
 'src/sage/categories/finite_posets.py  # 15 doctests failed',
 'src/sage/graphs/generic_graph.py  # 18 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/dynamics/arithmetic_dynamics/wehlerK3.py  # 21 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 21 doctests failed',
 'src/sage/misc/explain_pickle.py  # 70 doctests failed'

comment:212 Changed 4 years ago by John Palmieri

Re

 'src/sage/symbolic/constants.py  # 12 doctests failed',

I only see 6 failed doctests (this is on OS X; is it platform dependent?).

comment:213 Changed 4 years ago by David Coudert

There are certainly some differences between plateforms and other factors. For instance, I see this, which is not in the reported worst 15:

sage -t --long src/sage/graphs/digraph.py  # 14 doctests failed

I had 14 with 8.7.beta1, only 7 with beta2 and beta3, and now 14 again. All these failed doctests are related to the order of items in the output. See #27170.

comment:214 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:215 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:216 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:217 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:218 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:219 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:220 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:221 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

worst 15 in 8.7.b5:

['src/sage/numerical/backends/cvxopt_backend.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 9 doctests failed',
 'src/sage/crypto/lwe.py  # 10 doctests failed',
 'src/sage/misc/test_class_pickling.py  # 10 doctests failed',
 'src/sage/numerical/sdp.pyx  # 10 doctests failed',
 'src/sage/matroids/graphic_matroid.py  # 11 doctests failed',
 'src/sage/schemes/product_projective/point.py  # 11 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/categories/finite_posets.py  # 15 doctests failed',
 'src/sage/graphs/generic_graph.py  # 18 doctests failed',
 'src/sage/matroids/matroid.pyx  # 18 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/misc/explain_pickle.py  # 70 doctests failed']

comment:222 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:223 Changed 4 years ago by Jori Mäntysalo

Description: modified (diff)

comment:224 Changed 4 years ago by vklein

Description: modified (diff)

comment:225 Changed 4 years ago by vklein

Description: modified (diff)

comment:226 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)

comment:227 Changed 4 years ago by Jeroen Demeyer

Is there an easy place where we can find a full log of all Python 3 test failures?

comment:229 Changed 4 years ago by vklein

Description: modified (diff)

comment:230 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

in 8.7.b6:

less than 1 : 55
less than 2 : 78
less than 4 : 106
less than 8 : 124
less than 16 : 134

and the worst 15 are:

['src/sage/libs/eclib/interface.py  # 8 doctests failed',
 'src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/libs/ppl.pyx  # 9 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/numerical/backends/cvxopt_backend.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 9 doctests failed',
 'src/sage/crypto/lwe.py  # 10 doctests failed',
 'src/sage/misc/test_class_pickling.py  # 10 doctests failed',
 'src/sage/numerical/sdp.pyx  # 10 doctests failed',
 'src/sage/schemes/product_projective/point.py  # 11 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/matroids/matroid.pyx  # 22 doctests failed']

comment:231 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:232 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:233 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:234 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:235 Changed 4 years ago by vklein

Description: modified (diff)

comment:236 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:237 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:238 Changed 4 years ago by John Palmieri

When the next beta comes out, I think it will merge all of the algebra branches, and then we can move that out of the "in progress" list.

comment:239 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

on 8.7.b7:

less than 1 : 44
less than 2 : 64
less than 4 : 93
less than 8 : 111
less than 16 : 118

and the 15 worse are

['src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/numerical/backends/cvxopt_backend.pyx  # 8 doctests failed',
 'src/sage/numerical/sdp.pyx  # 8 doctests failed',
 'src/sage/symbolic/expression.pyx  # 8 doctests failed',
 'src/sage/libs/ppl.pyx  # 9 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/crypto/lwe.py  # 10 doctests failed',
 'src/sage/schemes/product_projective/point.py  # 11 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/quiver.py  # 13 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 18 doctests failed',
 'src/sage/matroids/matroid.pyx  # 18 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed']

comment:240 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:241 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:242 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:243 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:244 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:245 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:246 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:247 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:248 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:249 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:250 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)
Milestone: sage-8.7sage-8.8

in 8.7.rc0: worst 15 are

['src/sage/groups/perm_gps/permgroup.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/numerical/backends/cvxopt_backend.pyx  # 8 doctests failed',
 'src/sage/numerical/sdp.pyx  # 8 doctests failed',
 'src/sage/libs/ppl.pyx  # 9 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 10 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/quiver.py  # 14 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 18 doctests failed',
 'src/sage/matroids/matroid.pyx  # 18 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed']

and there remains

less than 1 : 35
less than 2 : 56
less than 4 : 83
less than 8 : 95
less than 16 : 101
less than 64 : 105
less than 128 : 105
less than 256 : 105

comment:251 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:252 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:253 Changed 4 years ago by John Palmieri

Is there a followup ticket to modify src/ext/doctest/python3-known-passing.txt? Should that happen for every beta, or just every actual release? Anyway, we should add algebras, data_structures, homology, modular, modules, schemes/curves, schemes/product_projective. What am I missing?

comment:254 Changed 4 years ago by Frédéric Chapoton

yes, this should be done from time to time. If you want to do that, please do! Now would be a good time. Here is my most recent list of good modules:

good = ["algebras", "algebras/steenrod", "arith", "coding",
        "calculus", "combinat/designs", "combinat/posets",
        "combinat/species", "combinat/rigged_configurations",
        "combinat/sf", "combinat/words", "databases",
        "data_structures", "docs", "features", "finance", "games",
        "game_theory", "groups/lie_gps", "groups/matrix_gps",
        "homology", "interacts", "knots", "libs/gsl", "lfunctions",
        "logic", "manifolds", "media", "modular/modsym", "modular",
        "modules", "monoids", "parallel", "plot", "probability",
        "quadratic_forms", "quivers", "rings/asymptotic",
        "rings/function_field", "rings/number_field", "sandpiles",
        "sat", "schemes/toric", "schemes/curves",
        "schemes/product_projective", "server", "stats", "structure",
        "tensor", "typeset", 'sage_setup']

comment:255 Changed 4 years ago by John Palmieri

See #27519. I'll post a branch there once I've finished testing.

comment:256 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:257 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:258 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:259 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

In 8.8.b0:

less than 1 : 33
less than 2 : 54
less than 4 : 80
less than 8 : 92
less than 16 : 99
less than 64 : 102

and the worst 15 are

['src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/groups/perm_gps/permgroup.py  # 7 doctests failed',
 'src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/numerical/backends/cvxopt_backend.pyx  # 8 doctests failed',
 'src/sage/numerical/sdp.pyx  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 9 doctests failed',
 'src/sage/graphs/generic_graph.py  # 10 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 13 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/quiver.py  # 13 doctests failed',
 'src/sage/matroids/matroid.pyx  # 18 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed']

comment:260 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:261 Changed 4 years ago by vklein

Description: modified (diff)

comment:262 Changed 4 years ago by vklein

Description: modified (diff)

comment:263 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:264 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:265 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:266 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:267 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:268 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:269 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

Little regression after passing to python 3.7.3:

less than 1 : 36
less than 2 : 56
less than 4 : 84
less than 8 : 94
less than 16 : 102
less than 64 : 105

In the 15 worst files, 178 broken doctests:

['src/sage/groups/perm_gps/permgroup.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/numerical/backends/cvxopt_backend.pyx  # 8 doctests failed',
 'src/sage/doctest/sources.py  # 9 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/numerical/sdp.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 9 doctests failed',
 'src/sage/symbolic/constants.py  # 12 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 13 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/quiver.py  # 14 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 22 doctests failed']
Last edited 4 years ago by Frédéric Chapoton (previous) (diff)

comment:270 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:271 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:272 Changed 4 years ago by vklein

Description: modified (diff)

comment:273 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:274 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:275 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:276 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:277 Changed 4 years ago by vklein

Description: modified (diff)

comment:278 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

Some progress in 8.8.b2:

less than 1 : 34
less than 2 : 54
less than 4 : 77
less than 8 : 86
less than 16 : 91
less than 64 : 94

In the 15 worst files, 163 broken doctests:

['src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 5 doctests failed',
 'src/sage/ext/fast_callable.pyx  # 6 doctests failed',
 'src/sage/groups/perm_gps/permgroup.py  # 6 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial.pyx  # 6 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 12 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 13 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/quiver.py  # 13 doctests failed',
 'src/sage/matroids/matroid.pyx  # 19 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 22 doctests failed']

comment:279 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:280 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:281 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:282 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:283 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:284 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:285 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

on 8.8.b3:

less than 1 : 32
less than 2 : 48
less than 4 : 67
less than 8 : 74
less than 16 : 80
less than 64 : 82

In the 15 worst files, 153 broken doctests:

['src/sage/rings/polynomial/binary_form_reduce.py  # 5 doctests failed',
 'src/sage/ext/fast_callable.pyx  # 6 doctests failed',
 'src/sage/groups/perm_gps/permgroup.py  # 6 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial.pyx  # 6 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 10 doctests failed',
 'src/sage/combinat/finite_state_machine.py  # 11 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 13 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/quiver.py  # 14 doctests failed',
 'src/sage/misc/classcall_metaclass.pyx  # 20 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed']

comment:286 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:287 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:288 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:289 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:290 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:291 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:292 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:293 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:294 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:295 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:296 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:297 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

In the 15 worst files, 125 broken doctests:

['src/sage/combinat/set_partition.py  # 5 doctests failed',
 'src/sage/dynamics/arithmetic_dynamics/projective_ds.py  # 5 doctests failed',
 'src/sage/rings/polynomial/binary_form_reduce.py  # 5 doctests failed',
 'src/sage/ext/fast_callable.pyx  # 6 doctests failed',
 'src/sage/groups/perm_gps/permgroup.py  # 6 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial.pyx  # 6 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 7 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/libs/ntl/ntl_ZZ_pX.pyx  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/rings/qqbar.py  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 12 doctests failed',
 'src/sage/matroids/matroid.pyx  # 23 doctests failed']

One can note a large regression in qqbar, and that matroids still get worse too.

comment:298 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:299 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:300 Changed 4 years ago by John Palmieri

Regarding matroids: there is some piece of underlying data which is intrinsically unordered, and it is causing all sorts of failures. I don't know if it's best to mark them all # py3 random or to sort the data so this doesn't happen. Is there an active Sage developer who knows enough about matroids to help make this decision?

comment:301 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:302 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:303 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:304 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:305 Changed 4 years ago by vklein

Description: modified (diff)

comment:306 Changed 4 years ago by vklein

Description: modified (diff)

comment:307 Changed 4 years ago by vklein

Description: modified (diff)

comment:308 Changed 4 years ago by vklein

Description: modified (diff)

comment:309 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:310 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

With 8.8.b5:

less than 1 : 22
less than 2 : 30
less than 4 : 48
less than 8 : 52
less than 16 : 55
less than 64 : 56

In the 15 worst files, 102 broken doctests:

['src/sage/combinat/root_system/integrable_representations.py  # 4 doctests failed',
 'src/sage/combinat/set_partition.py  # 4 doctests failed',
 'src/sage/doctest/test.py  # 4 doctests failed',
 'src/sage/matroids/graphic_matroid.py  # 4 doctests failed',
 'src/sage/misc/functional.py  # 4 doctests failed',
 'src/sage/repl/attach.py  # 4 doctests failed',
 'src/sage/rings/polynomial/toy_buchberger.py  # 4 doctests failed',
 'src/sage/groups/perm_gps/permgroup.py  # 6 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 7 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/symbolic/expression.pyx  # 10 doctests failed',
 'src/sage/matroids/matroid.pyx  # 18 doctests failed']

comment:311 Changed 4 years ago by David Coudert

Description: modified (diff)

#27773 and #27774 fix various issues in Python 3 with src/sage/numerical/backends/cplex_backend.pyx and 1 in gurobi_backend.pyx. Cplex <= 12.8 is needed to test these tickets. Cplex >= 12.9 cannot be used yet (see #27790).

comment:312 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:313 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:314 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:315 Changed 4 years ago by Salvatore Stella

#27854 deals with the rest of cluster_algebra_seed apart from one doctest that fails intermittently.

comment:316 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:317 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

In sage 8.8.b6, some progress:

less than 1 : 20
less than 2 : 27
less than 4 : 42
less than 8 : 46
less than 16 : 48
less than 64 : 49

In the 15 worst files, 96 broken doctests:

['src/sage/geometry/polyhedron/ppl_lattice_polytope.py  # 3 doctests failed',
 'src/sage/misc/sageinspect.py  # 3 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 3 doctests failed',
 'src/sage/rings/valuation/inductive_valuation.py  # 3 doctests failed',
 'src/sage/matroids/graphic_matroid.py  # 4 doctests failed',
 'src/sage/misc/functional.py  # 4 doctests failed',
 'src/sage/repl/attach.py  # 4 doctests failed',
 'src/sage/rings/polynomial/toy_buchberger.py  # 4 doctests failed',
 'src/sage/combinat/cluster_algebra_quiver/cluster_seed.py  # 7 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/symbolic/expression.pyx  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed']

comment:318 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:319 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:320 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:321 Changed 4 years ago by vklein

Description: modified (diff)

comment:322 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:323 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

moved matroids to the "work in progress section"

comment:324 Changed 4 years ago by Markus Wageringel

If no one is working on it yet, I will look into multi_polynomial_ideal and toy_buchberger.

comment:325 in reply to:  323 Changed 4 years ago by John Palmieri

Replying to chapoton:

moved matroids to the "work in progress section"

Oops. Thank you for fixing that.

comment:326 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:327 in reply to:  324 Changed 4 years ago by John Palmieri

Replying to gh-mwageringel:

If no one is working on it yet, I will look into multi_polynomial_ideal and toy_buchberger.

Sure, but make sure to check #27791: closed but not yet merged into a beta release.

Edit: oh, sorry, that deals with multi_polynomial, and you were talking about multi_polynomial_ideal. I don't see any relevant tickets, so please go ahead.

Last edited 4 years ago by John Palmieri (previous) (diff)

comment:328 Changed 4 years ago by John Palmieri

Description: modified (diff)

comment:329 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

in 8.8.b7:

less than 1 : 18
less than 2 : 25
less than 4 : 38
less than 8 : 41
less than 16 : 43
less than 64 : 44

In the 15 worst files, 92 broken doctests:

['src/sage/combinat/root_system/weyl_characters.py  # 3 doctests failed',
 'src/sage/combinat/set_partition_ordered.py  # 3 doctests failed',
 'src/sage/doctest/test.py  # 3 doctests failed',
 'src/sage/misc/sageinspect.py  # 3 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 3 doctests failed',
 'src/sage/rings/polynomial/toy_buchberger.py  # 3 doctests failed',
 'src/sage/matroids/graphic_matroid.py  # 4 doctests failed',
 'src/sage/misc/functional.py  # 4 doctests failed',
 'src/sage/repl/attach.py  # 4 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/symbolic/expression.pyx  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed',
 'src/sage/matroids/matroid.pyx  # 21 doctests failed']

comment:330 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:331 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:332 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:333 Changed 4 years ago by Markus Wageringel

Description: modified (diff)

comment:334 Changed 4 years ago by Markus Wageringel

Description: modified (diff)

comment:335 Changed 4 years ago by vklein

Description: modified (diff)

comment:336 Changed 4 years ago by vklein

Description: modified (diff)

comment:337 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

in 8.8.rc0:

less than 1 : 12
less than 2 : 16
less than 4 : 28
less than 8 : 30
less than 16 : 32

In the 15 worst files, 69 broken doctests:

['src/sage/combinat/crystals/kirillov_reshetikhin.py  # 3 doctests failed',
 'src/sage/combinat/perfect_matching.py  # 3 doctests failed',
 'src/sage/combinat/root_system/root_lattice_realizations.py  # 3 doctests failed',
 'src/sage/combinat/root_system/weyl_characters.py  # 3 doctests failed',
 'src/sage/doctest/test.py  # 3 doctests failed',
 'src/sage/misc/sageinspect.py  # 3 doctests failed',
 'src/sage/rings/polynomial/multi_polynomial_ideal.py  # 3 doctests failed',
 'src/sage/symbolic/expression.pyx  # 3 doctests failed',
 'src/sage/misc/functional.py  # 4 doctests failed',
 'src/sage/repl/attach.py  # 4 doctests failed',
 'src/sage/rings/polynomial/toy_buchberger.py  # 4 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed']

comment:338 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:339 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:340 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:341 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:342 Changed 4 years ago by Frédéric Chapoton

Description: modified (diff)

comment:343 Changed 3 years ago by vklein

Description: modified (diff)

comment:344 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:345 Changed 3 years ago by Frédéric Chapoton

EDIT wrong ticket

Last edited 3 years ago by Frédéric Chapoton (previous) (diff)

comment:346 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:347 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:348 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:349 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:350 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:351 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:352 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:353 Changed 3 years ago by vklein

Description: modified (diff)

comment:354 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:355 Changed 3 years ago by Erik Bray

Milestone: sage-8.8

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

comment:356 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:357 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:358 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:359 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:360 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:361 Changed 3 years ago by vklein

Description: modified (diff)

comment:362 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:363 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:364 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:365 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:366 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:367 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

In 8.9.beta0:

less than 1 : 9
less than 2 : 12
less than 4 : 17
less than 8 : 20
less than 16 : 22

In the 15 worst files, 64 broken doctests:

['src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed',
 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed',
 'src/sage/combinat/finite_state_machine.py  # 2 doctests failed',
 'src/sage/doctest/test.py  # 2 doctests failed',
 'src/sage/numerical/backends/generic_backend.pyx  # 2 doctests failed',
 'src/sage/combinat/perfect_matching.py  # 3 doctests failed',
 'src/sage/combinat/root_system/root_lattice_realizations.py  # 3 doctests failed',
 'src/sage/combinat/root_system/weyl_characters.py  # 3 doctests failed',
 'src/sage/misc/functional.py  # 4 doctests failed',
 'src/sage/repl/attach.py  # 4 doctests failed',
 'src/sage/symbolic/expression.pyx  # 6 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed']

There is an unexpected failure in 8.9.beta0 in the schemes folder :

sage -t --long src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py  # 1 doctest failed on line 780

comment:368 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:369 Changed 3 years ago by Markus Wageringel

Description: modified (diff)

comment:370 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:371 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:372 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:373 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

For 8.9.b2: In the 15 worst files, 55 broken doctests:

['src/sage/libs/singular/function.pyx  # 1 doctest failed',
 'src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py  # 1 doctest failed',
 'src/sage/symbolic/expression.pyx  # 1 doctest failed',
 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed',
 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed',
 'src/sage/doctest/test.py  # 2 doctests failed',
 'src/sage/numerical/backends/generic_backend.pyx  # 2 doctests failed',
 'src/sage/combinat/perfect_matching.py  # 3 doctests failed',
 'src/sage/combinat/root_system/root_lattice_realizations.py  # 3 doctests failed',
 'src/sage/combinat/root_system/weyl_characters.py  # 3 doctests failed',
 'src/sage/repl/attach.py  # 4 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/graphs/generic_graph.py  # 8 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed',
 'src/sage/rings/integer.pyx  # 9 doctests failed']

comment:374 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

apparently, new regression here:

sage -t --long src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx  # 1 doctest failed

comment:375 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:376 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:377 Changed 3 years ago by vklein

Description: modified (diff)

comment:378 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:379 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:380 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:381 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:382 Changed 3 years ago by vklein

Description: modified (diff)

comment:383 Changed 3 years ago by vklein

Description: modified (diff)

comment:384 Changed 3 years ago by vklein

Description: modified (diff)

comment:385 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:386 Changed 3 years ago by Markus Wageringel

Description: modified (diff)

comment:387 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:388 Changed 3 years ago by John Palmieri

Can anyone provide any more information on the "fragile" doctests? In repeated runs, I get no failures (on OS X) with

./sage -tp --long src/sage/repl src/sage/numerical/ src/sage/libs

For the doctest failures in french_book, it is not clear to me what sort of changes are allowed, since the book is now in press. Should the failing tests just be marked as # py2 until the authors present a better solution?

comment:389 Changed 3 years ago by Markus Wageringel

The failures can be seen in the logs of the Python 3 patchbot: https://patchbot.sagemath.org/ticket/0/. Without being able to reproduce these, they still seem pretty difficult to solve though.

comment:390 Changed 3 years ago by John Palmieri

Description: modified (diff)

comment:391 Changed 3 years ago by Markus Wageringel

Description: modified (diff)

comment:392 Changed 3 years ago by Jean-Philippe Labbé

Description: modified (diff)

comment:393 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

status on 8.9.beta4: remains 12 files with a total of 33 failing doctests:

'src/sage/combinat/root_system/non_symmetric_macdonald_polynomials.py  # 1 doctest failed',
 'src/sage/libs/singular/function.pyx  # 1 doctest failed',
 'src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py  # 1 doctest failed',
 'src/sage/symbolic/expression.pyx  # 1 doctest failed',
 'src/sage/tests/books/computational-mathematics-with-sagemath/graphtheory_doctest.py  # 1 doctest failed',
 'src/sage/tests/books/computational-mathematics-with-sagemath/sol/graphtheory_doctest.py  # 1 doctest failed',
 'src/sage/doctest/test.py  # 2 doctests failed',
 'src/sage/numerical/backends/generic_backend.pyx  # 2 doctests failed',
 'src/sage/combinat/root_system/weyl_characters.py  # 3 doctests failed',
 'src/sage/repl/attach.py  # 4 doctests failed',
 'src/sage/combinat/root_system/weyl_group.py  # 7 doctests failed',
 'src/sage/misc/nested_class.pyx  # 9 doctests failed'

comment:394 Changed 3 years ago by David Coudert

Yes, the 8 last failing doctests in generic_graph.py have been fixed with #27232. So, all doctests in the standard graphs module are now fixed !!!

We still have some failing doctests in optional packages like plantri #28108. I have now yet checked all other optional packages. Do we have a meta-ticket to record them ?

comment:395 Changed 3 years ago by John Palmieri

Is this a new one? All tests in schemes are supposed to pass.

'src/sage/schemes/hyperelliptic_curves/hyperelliptic_finite_field.py  # 1 doctest failed'

comment:396 Changed 3 years ago by Frédéric Chapoton

I think I have seen that already in previous betas, maybe since 8.9.beta3 or before.

Version 0, edited 3 years ago by Frédéric Chapoton (next)

comment:397 Changed 3 years ago by John Palmieri

Is there a ticket for it? What's the error? (I don't see it on my OS X machines.)

comment:398 Changed 3 years ago by vklein

I don't have it either on ubuntu 16.04.

comment:399 Changed 3 years ago by Frédéric Chapoton

There is no ticket for this error in schemes. The exact error can be seen in the patchbot log:

https://patchbot.sagemath.org/log/0/Ubuntu/16.04/x86_64/4.4.0-148-generic/atlas/2019-07-29%2008:49:23?short

This patchtbot is running on an ubuntu 16.04, using gcc 8.3.0.

Maybe we should start a new ticket for the final polishing ? This one is very long already.

comment:400 in reply to:  399 Changed 3 years ago by John Palmieri

Replying to chapoton:

Maybe we should start a new ticket for the final polishing ? This one is very long already.

Good idea. It's great seeing the progress!

comment:401 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

I have created #28298 for the few remaining final steps.

comment:402 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

LARGE SCALE REGRESSION in 8.9.b5, with 241 failing doctests !!!!

EDIT: This could have been caused by a wrong version of gcc being used. Will retry.

Last edited 3 years ago by Frédéric Chapoton (previous) (diff)

comment:403 in reply to:  402 Changed 3 years ago by John Palmieri

Replying to chapoton:

LARGE SCALE REGRESSION in 8.9.b5, with 241 failing doctests !!!!

EDIT: This could have been caused by a wrong version of gcc being used. Will retry.

For what it's worth, on OS X I only see one new failure, due to #28225, a proposed fix at #28320.

comment:404 in reply to:  402 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

Replying to chapoton:

LARGE SCALE REGRESSION in 8.9.b5, with 241 failing doctests !!!!

EDIT: This could have been caused by a wrong version of gcc being used. Will retry.

This was a false alert, due to a wrong gcc. There are 18 failing doctests.

comment:405 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:406 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:407 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:408 Changed 3 years ago by Frédéric Chapoton

Description: modified (diff)

comment:409 Changed 3 years ago by Frédéric Chapoton

Milestone: sage-duplicate/invalid/wontfix
Resolution: worksforme
Status: newclosed
Note: See TracTickets for help on using tickets.