Opened 6 months ago

Closed 5 months ago

#26211 closed enhancement (fixed)

py3: fix doctests in quivers/

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f1c2207 (Commits) Commit: f1c2207ba84cedb03fbf9e2ec01c12f8857192e2
Dependencies: #26220 Stopgaps:

Description (last modified by chapoton)

with an important fix to CoercionException?

Change History (9)

comment:1 Changed 6 months ago by chapoton

  • Branch set to u/chapoton/26211
  • Commit set to 8ef7eb7b4a197a9f996b806c33810f5cefd2b9fd
  • Status changed from new to needs_review

New commits:

​8ef7eb7py3: fix doctests in quivers/

comment:2 Changed 6 months ago by chapoton

  • Description modified (diff)

comment:3 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 6 months ago by tscrim

  • Status changed from positive_review to needs_work

The CoercionException is also fixed in #26220, but I think we should do it there as it gives better reference for the change. Please remove it from here.

comment:5 Changed 6 months ago by jhpalmieri

Sorry for the conflict.

comment:6 Changed 5 months ago by git

  • Commit changed from 8ef7eb7b4a197a9f996b806c33810f5cefd2b9fd to f1c2207ba84cedb03fbf9e2ec01c12f8857192e2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​f1c2207py3: fix doctests in quivers/

comment:7 Changed 5 months ago by chapoton

  • Dependencies set to #26220
  • Status changed from needs_work to needs_review

comment:8 Changed 5 months ago by tscrim

  • Status changed from needs_review to positive_review

Thank you.

comment:9 Changed 5 months ago by vbraun

  • Branch changed from u/chapoton/26211 to f1c2207ba84cedb03fbf9e2ec01c12f8857192e2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.