Opened 3 years ago

Closed 3 years ago

#26207 closed enhancement (fixed)

py3: fix doctests for universal cyclotomic field

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.4
Component: python3 Keywords:
Cc: vklein Merged in:
Authors: Frédéric Chapoton Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: e4a73fe (Commits, GitHub, GitLab) Commit: e4a73fe08c8f8db1dfa52cc10f0ad2a6fa2aa9f3
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26207
  • Cc vklein added
  • Commit set to e4a73fe08c8f8db1dfa52cc10f0ad2a6fa2aa9f3
  • Status changed from new to needs_review

New commits:

e4a73fepy3: make doctest pass in universal cyclotomic field

comment:2 Changed 3 years ago by vklein

  • Owner changed from (none) to vklein

comment:3 Changed 3 years ago by chapoton

For what is really happening here, see the discussion at the end of #24258

comment:4 Changed 3 years ago by vklein

I will look at it immediately because yes your fix work but i didn't know why.

comment:5 Changed 3 years ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

Ok i see. Looks good to me.

comment:6 Changed 3 years ago by vklein

  • Owner changed from vklein to (none)

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26207 to e4a73fe08c8f8db1dfa52cc10f0ad2a6fa2aa9f3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.