#26197 closed defect (fixed)

Fix use of Baker's theorem for determination of differentials

Reported by: nbruin Owned by:
Priority: major Milestone: sage-8.4
Component: geometry Keywords:
Cc: Merged in:
Authors: Nils Bruin Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: a0f77da (Commits) Commit: a0f77daec0de42f952510cd4cca5cfb97af3cf11
Dependencies: Stopgaps:

Description

In sage.schemes.riemann_surfaces.riemann_surface.differential_basis_baker we need some further genericity check.

Change History (6)

comment:1 Changed 12 months ago by nbruin

  • Branch set to u/nbruin/baker_differentials

comment:2 Changed 12 months ago by nbruin

  • Authors set to Nils Bruin
  • Commit set to 8bcc044995c5b344078d6e907ca739e3dee808da
  • Status changed from new to needs_review

Code is fixed and test included.


New commits:

8bcc044trac 26197: fix use of Baker's theorem for differentials

comment:3 Changed 12 months ago by chapoton

for python3 compatibility, do not use .iteritems but .items

comment:4 Changed 12 months ago by git

  • Commit changed from 8bcc044995c5b344078d6e907ca739e3dee808da to a0f77daec0de42f952510cd4cca5cfb97af3cf11

Branch pushed to git repo; I updated commit sha1. New commits:

a0f77dapython3 compatibility

comment:5 Changed 12 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:6 Changed 12 months ago by vbraun

  • Branch changed from u/nbruin/baker_differentials to a0f77daec0de42f952510cd4cca5cfb97af3cf11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.