Opened 4 years ago
Closed 4 years ago
#26196 closed enhancement (fixed)
cleanup the imports of Eta products in global namespace
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.4 |
Component: | refactoring | Keywords: | |
Cc: | vdelecroix | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Vincent Delecroix |
Report Upstream: | N/A | Work issues: | |
Branch: | 230d71f (Commits, GitHub, GitLab) | Commit: | 230d71f5957453a176b48029fa8ed619abd3a227 |
Dependencies: | Stopgaps: |
Description
part of #25383
Change History (10)
comment:1 Changed 4 years ago by
- Branch set to u/chapoton/26196
- Commit set to c69ce6efa2847630a7ab19ed23105a9f6c95a60b
- Component changed from PLEASE CHANGE to refactoring
- Status changed from new to needs_review
- Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 4 years ago by
- Commit changed from c69ce6efa2847630a7ab19ed23105a9f6c95a60b to b000350a6384bf87ae90b0fd32e8823e68528809
Branch pushed to git repo; I updated commit sha1. New commits:
b000350 | fix
|
comment:3 Changed 4 years ago by
- Commit changed from b000350a6384bf87ae90b0fd32e8823e68528809 to 8c57b113e61188a49e24ecc5204d1e2a7c8eb7d0
comment:5 Changed 4 years ago by
Because you touched it, can you make the assert a ValueError
? assert is not intended to check user input at all.
comment:6 Changed 4 years ago by
- Reviewers set to Vincent Delecroix
comment:7 Changed 4 years ago by
- Commit changed from 8c57b113e61188a49e24ecc5204d1e2a7c8eb7d0 to 230d71f5957453a176b48029fa8ed619abd3a227
Branch pushed to git repo; I updated commit sha1. New commits:
230d71f | using raise instead of assert to check prec input of eta expansion
|
comment:8 Changed 4 years ago by
done, thanks
comment:9 Changed 4 years ago by
- Status changed from needs_review to positive_review
comment:10 Changed 4 years ago by
- Branch changed from u/chapoton/26196 to 230d71f5957453a176b48029fa8ed619abd3a227
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
cleanup and deprecate imports for Eta products