Opened 3 years ago

Closed 3 years ago

#26190 closed defect (fixed)

Upgrade latte_int to 1.7.5

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-8.5
Component: packages: optional Keywords:
Cc: tscrim Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik, Travis Scrimshaw
Report Upstream: N/A Work issues: Back out #18887, fixed upstream
Branch: 9673bbb (Commits, GitHub, GitLab) Commit: 9673bbb41535ba1860d4a40e407c4f38414ad013
Dependencies: Stopgaps:

Status badges

Change History (14)

comment:1 Changed 3 years ago by tscrim

  • Cc tscrim added

comment:2 Changed 3 years ago by dimpase

1.7.3 does not build on FreeBSD 12 (also without Lidia, which is broken there), but 1.7.5 does. So this is something needed for FreeBSD becoming a 1st tier platform (see #26249).

comment:3 Changed 3 years ago by dimpase

please provide a link to the tarball in the ticket description.

comment:4 Changed 3 years ago by dimpase

  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 3 years ago by dimpase

  • Branch set to public/packages/latte175update
  • Commit set to 8c59f18911f067a9db66f48041a3d88c0d5d8dba

New commits:

8c59f18bump up the version etc

comment:6 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik

I've checked that this works on Linux x86_64 (also with SAGE_CHECK=yes) and on FreeBSD. Please feel free to check it for yourself and make it positive review.

comment:7 Changed 3 years ago by dimpase

  • Milestone changed from sage-8.4 to sage-8.5
  • Type changed from enhancement to defect

marked as defect, as there are platforms for which it makes a difference from failure to working...

comment:8 Changed 3 years ago by mkoeppe

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Work issues set to Back out #18887, fixed upstream

comment:9 Changed 3 years ago by git

  • Commit changed from 8c59f18911f067a9db66f48041a3d88c0d5d8dba to 9673bbb41535ba1860d4a40e407c4f38414ad013

Branch pushed to git repo; I updated commit sha1. New commits:

9673bbbbacked out #18887

comment:10 Changed 3 years ago by dimpase

  • Status changed from needs_work to needs_review

comment:11 Changed 3 years ago by dimpase

ping?

comment:12 Changed 3 years ago by tscrim

I am ready to set a positive review unless Matthias has any other comments.

comment:13 Changed 3 years ago by tscrim

  • Reviewers changed from Dima Pasechnik to Dima Pasechnik, Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:14 Changed 3 years ago by vbraun

  • Branch changed from public/packages/latte175update to 9673bbb41535ba1860d4a40e407c4f38414ad013
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.