Opened 4 years ago

Closed 4 years ago

#26176 closed defect (fixed)

SageKernelSpec doctests fail in non-standard setups

Reported by: Julian Rüth Owned by:
Priority: major Milestone: sage-8.5
Component: build Keywords:
Cc: Timo Kaufmann, Jeroen Demeyer Merged in:
Authors: Julian Rüth Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: dacbb47 (Commits, GitHub, GitLab) Commit: dacbb470150a1be92af5367e880fdb939458ee84
Dependencies: Stopgaps:

Status badges

Description

In Debian's setup most SageKernelSpec doctests fail because Sage isn't installed in the final location when the doctest run and therefore _mkdirs() fails as it can't write to /usr/share.

In any case, setup.py installs into install_data but the doctests don't run there. We could probably just have the tests run there as well but also much of the tests that perform writes don't work there and are therefore disabled. I can see why the tests are the way they are but I don't think it's worth it. I think it's easier for packagers and good enough for SageMath to just run all the tests in temporary places.

Change History (10)

comment:1 Changed 4 years ago by Julian Rüth

Branch: u/saraedum/26176

comment:2 Changed 4 years ago by Julian Rüth

Authors: Julian Rüth
Commit: 32b262d43711f7901cfaed43f6a0d7fa3c9bff34
Status: newneeds_review

New commits:

32b262dMake SageKernelSpec tests pass if Sage is not installed yet

comment:3 Changed 4 years ago by Timo Kaufmann

I'm confused, isn't that the same fix as in #25722?

comment:4 Changed 4 years ago by Julian Rüth

Yes, sort of. But #25722 only does that for the symlinks. Here I do the same for all the _mkdirs() calls.

comment:5 in reply to:  description Changed 4 years ago by Jeroen Demeyer

Reviewers: Jeroen Demeyer
Status: needs_reviewpositive_review

comment:6 Changed 4 years ago by Julian Rüth

Status: positive_reviewneeds_work

comment:7 Changed 4 years ago by git

Commit: 32b262d43711f7901cfaed43f6a0d7fa3c9bff34dacbb470150a1be92af5367e880fdb939458ee84

Branch pushed to git repo; I updated commit sha1. New commits:

dacbb47Fix a classmethod test

comment:8 Changed 4 years ago by Julian Rüth

Status: needs_workneeds_review

Sorry, I had missed this confusing invocation.

comment:9 Changed 4 years ago by François Bissey

Milestone: sage-8.4sage-8.5
Status: needs_reviewpositive_review

I think this can be safely put back to positive review.

comment:10 Changed 4 years ago by Volker Braun

Branch: u/saraedum/26176dacbb470150a1be92af5367e880fdb939458ee84
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.