Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26175 closed enhancement (fixed)

another typo ticket (2018-09)

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.5
Component: documentation Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 5428212 (Commits, GitHub, GitLab) Commit: 54282128f5673070daf3854e0e902bb998b633a0
Dependencies: Stopgaps:

Status badges

Change History (11)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/26175
  • Commit set to 59f6bc6e62240392ef57159b1592214ca3268c86
  • Status changed from new to needs_review

New commits:

59f6bc6another typo ticket

comment:2 Changed 4 years ago by jmantysalo

  • Description modified (diff)
  • Reviewers set to Jori Mäntysalo
  • Status changed from needs_review to needs_work

comment:3 Changed 4 years ago by jmantysalo

  • Description modified (diff)

"orientation- preserving" should be written without a space.

Also, I do not know the area, so should it be "the list" or "a list". Hence someone else should check this.

Otherwise all seems to be good.

comment:4 Changed 4 years ago by jmantysalo

Btw, for next typo ticket: egrep -R '^[^#]+[a-z]-$' src/sage

comment:5 Changed 4 years ago by git

  • Commit changed from 59f6bc6e62240392ef57159b1592214ca3268c86 to f396bd0af4491f27e94a591220bad4e4b9fa4de6

Branch pushed to git repo; I updated commit sha1. New commits:

f396bd0details

comment:6 Changed 4 years ago by git

  • Commit changed from f396bd0af4491f27e94a591220bad4e4b9fa4de6 to 54282128f5673070daf3854e0e902bb998b633a0

Branch pushed to git repo; I updated commit sha1. New commits:

5428212Merge branch 'u/chapoton/26175' in 8.4.rc0

comment:7 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:8 Changed 4 years ago by chapoton

review, please ?

comment:9 Changed 4 years ago by jmantysalo

  • Status changed from needs_review to positive_review

LGTM.

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/26175 to 54282128f5673070daf3854e0e902bb998b633a0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 4 years ago by embray

  • Milestone changed from sage-8.4 to sage-8.5

This should be re-targeted for 8.5.

Note: See TracTickets for help on using tickets.