Opened 3 years ago

Closed 3 years ago

#26169 closed enhancement (fixed)

py3: trying not to sort the edges of graphs (step 1)

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: tscrim, jmantysalo, dcoudert, jhpalmieri Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 2f40188 (Commits, GitHub, GitLab) Commit: 2f40188d64182e35433c64a13a68f8f8e3b3fd23
Dependencies: Stopgaps:

Status badges

Description


Change History (9)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26169
  • Commit set to 2f40188d64182e35433c64a13a68f8f8e3b3fd23

Here is a modest tentative to enhance the situation. Let us see if there remains failing doctests.


New commits:

2f40188trying not to sort the edges (step 1)

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim jmantysalo added
  • Status changed from new to needs_review

green bot, hourra !

comment:3 Changed 3 years ago by tscrim

  • Cc dcoudert jhpalmieri added

I am okay with this change, but I am cc-ing a few other people who might have an opinion on this.

comment:4 Changed 3 years ago by dcoudert

I'm also OK with this change.

comment:5 Changed 3 years ago by jhpalmieri

Sure, okay with me.

comment:6 Changed 3 years ago by chapoton

so, is this a positive review ?

comment:7 Changed 3 years ago by dcoudert

I'm currently compiling beta3 and will do some tests after that.

comment:8 Changed 3 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26169 to 2f40188d64182e35433c64a13a68f8f8e3b3fd23
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.