Opened 4 years ago

Closed 4 years ago

#26162 closed enhancement (fixed)

py3: enable hash for permutation groups

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: tscrim, embray, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 4d36441 (Commits, GitHub, GitLab) Commit: 4d36441e5b00aa0ef3ab0a28d5a320842534d871
Dependencies: Stopgaps:

Status badges


by removing one __eq__

part of #24551

Change History (6)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/test_hash_groupes
  • Commit set to 88dfd224af45d69d4ad7d324102ea4bd36f828c7
  • Status changed from new to needs_review

New commits:

88dfd22change __eq__ for perm groups

comment:2 Changed 4 years ago by chapoton

  • Cc tscrim embray jdemeyer added

One patchbot is green, although my own patchbot displays a strange doctest failure involving ECM (probably unrelated, but I am not sure).

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Almost certainly unrelated. Your TESTS:: block is over-indented; once changed you can set a positive review on my behalf.

comment:4 Changed 4 years ago by git

  • Commit changed from 88dfd224af45d69d4ad7d324102ea4bd36f828c7 to 4d36441e5b00aa0ef3ab0a28d5a320842534d871

Branch pushed to git repo; I updated commit sha1. New commits:

4d36441fix TESTS block alignement, and some pep8 details

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

ok. I have also added a few spaces for pep8.

Setting to positive.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/test_hash_groupes to 4d36441e5b00aa0ef3ab0a28d5a320842534d871
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.