Opened 3 years ago

Closed 8 months ago

#26161 closed defect (fixed)

Refine polynomial quotient rings to the finite subcategory on initialization

Reported by: saraedum Owned by:
Priority: major Milestone: sage-9.4
Component: finite rings Keywords:
Cc: Merged in:
Authors: Julian Rüth Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: d8c936d (Commits, GitHub, GitLab) Commit: d8c936d31706e6bed3b0bdbd42aa896885fb6408
Dependencies: Stopgaps:

Status badges

Description

Currently, the following test would not pass:

sage: R.<x> = GF(2)[]
sage: S = R.quo(x)
sage: S in FiniteFields()
True
sage: type(S).mro()
...
 <class 'sage.categories.finite_fields.FiniteFields.parent_class'>,
...

In other words, a finite polynomial quotient ring that is a field does not inherit ParentElements of the category of finite fields.

Change History (11)

comment:1 Changed 3 years ago by saraedum

  • Branch set to u/saraedum/26161

comment:2 Changed 3 years ago by saraedum

  • Commit set to 1df4877ef6ebb7b1310a4facc150401335105b61
  • Status changed from new to needs_review
  • Work issues set to is the patchbot happy?

New commits:

1df4877Refine polynomial quotient ring to the finite subcategory on initialization

comment:3 Changed 3 years ago by git

  • Commit changed from 1df4877ef6ebb7b1310a4facc150401335105b61 to 12fd85501b7af909b1bbee4cc9f5b4ae9be3400b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

12fd855Refine polynomial quotient ring to the finite subcategory on initialization

comment:4 Changed 3 years ago by vdelecroix

  • Status changed from needs_review to needs_work

This is now failing (see also patchbot reports)

sage: R1.<x> = GF(5)[]
sage: F1 = R1.quotient_ring(x^2+x+1)
sage: R2.<x> = F1[]
sage: F2 = R2.quotient_ring(x^2+x+1)

comment:5 Changed 3 years ago by git

  • Commit changed from 12fd85501b7af909b1bbee4cc9f5b4ae9be3400b to cc6db9e19e8b844d26f896d7562e004052d7dc38

Branch pushed to git repo; I updated commit sha1. New commits:

f58c876Merge 26161 and develop
cc6db9eMerge remote-tracking branch 'trac/develop' into 26161

comment:6 Changed 3 years ago by git

  • Commit changed from cc6db9e19e8b844d26f896d7562e004052d7dc38 to 0c054d0026019f30b737cac867c305590fcc76b9

Branch pushed to git repo; I updated commit sha1. New commits:

224f78dMerge remote-tracking branch 'trac/develop' into 26161
02d499dMerge branch '26161' and trac/develop
0c054d0Make morphisms between finite fields work again

comment:7 Changed 3 years ago by saraedum

  • Status changed from needs_work to needs_review

I fixed the failing doctests and tried to cleanup some of the error messages that I stumbled upon. Doctests in rings/ pass for me now, let's see what the patchbot thinks.

comment:8 Changed 14 months ago by git

  • Commit changed from 0c054d0026019f30b737cac867c305590fcc76b9 to d8c936d31706e6bed3b0bdbd42aa896885fb6408

Branch pushed to git repo; I updated commit sha1. New commits:

d8c936dMerge remote-tracking branch 'trac/develop' into HEAD

comment:9 Changed 9 months ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review
  • Work issues is the patchbot happy? deleted

Looks fine to me.

comment:10 Changed 9 months ago by chapoton

  • Milestone changed from sage-8.4 to sage-9.4

comment:11 Changed 8 months ago by vbraun

  • Branch changed from u/saraedum/26161 to d8c936d31706e6bed3b0bdbd42aa896885fb6408
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.