Opened 4 years ago

Closed 4 years ago

#26151 closed defect (fixed)

Kummer surface functionality fails

Reported by: sijsling Owned by:
Priority: major Milestone: sage-8.9
Component: algebraic geometry Keywords: kummer
Cc: kohel, slelievre Merged in:
Authors: Frédéric Chapoton Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: 3f5f59c (Commits, GitHub, GitLab) Commit: 3f5f59c8b7814443a358abbe1d8570c71c6b71b2
Dependencies: Stopgaps:

Status badges

Description

Currently the creation of the Kummer surface associated to a genus 2 curve fails. All three of the final statements in the following code return the same error. 

sage: R.<x> = QQ[]
sage: f = x^5 + x + 1
sage: X = HyperellipticCurve(f)
sage: J = Jacobian(X)

sage: K = KummerSurface(J)
sage: K = J.kummer_surface()
sage: phi = X.kummer_morphism()

Change History (8)

comment:1 Changed 4 years ago by slelievre

Cc: kohel slelievre added

comment:2 Changed 4 years ago by chapoton

Branch: → u/chapoton/26151
Commit: → 972750ff31e42e1cae9edfc3bd9f0cd672172006
Status: new → needs_review

Here is a fix.

Note an important change in the check inside the definition of projective morphisms..

New commits:

​972750ftrac 26151 fix Kummer surface and add doctest

comment:3 Changed 4 years ago by git

Commit: 972750ff31e42e1cae9edfc3bd9f0cd672172006 → 3f5f59c8b7814443a358abbe1d8570c71c6b71b2

Branch pushed to git repo; I updated commit sha1. New commits:

​82855a6Merge branch 'u/chapoton/26151' in 8.8
​3f5f59ctrac 26151 fix doctest in scheme morphisms

comment:4 Changed 4 years ago by chapoton

Authors: → Frédéric Chapoton

comment:5 Changed 4 years ago by chapoton

green bot, needs review

comment:6 Changed 4 years ago by slelievre

Keywords: kummer added
Reviewers: → Samuel Lelièvre
Status: needs_review → positive_review

Thanks for finding how to fix this.

comment:7 Changed 4 years ago by chapoton

Milestone: sage-8.4 → sage-8.9

comment:8 Changed 4 years ago by vbraun

Branch: u/chapoton/26151 → 3f5f59c8b7814443a358abbe1d8570c71c6b71b2
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.