Opened 4 years ago
Closed 4 years ago
#26146 closed defect (fixed)
py3: doctests AsymptoticRing
Reported by: | dkrenn | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.4 |
Component: | python3 | Keywords: | |
Cc: | behackl, cheuberg | Merged in: | |
Authors: | Daniel Krenn | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 2b124c5 (Commits, GitHub, GitLab) | Commit: | 2b124c5e0ab80a4330fddd8adc028685bc51d073 |
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (8)
comment:1 Changed 4 years ago by
- Cc behackl cheuberg added
comment:2 Changed 4 years ago by
- Description modified (diff)
comment:3 Changed 4 years ago by
comment:4 Changed 4 years ago by
- Branch set to u/dkrenn/asy-py3
comment:5 follow-up: ↓ 6 Changed 4 years ago by
- Commit set to 2b124c5e0ab80a4330fddd8adc028685bc51d073
- Status changed from new to needs_review
I've fixed the Python3-issues (tested with 8.5.beta2, but branch is based on 8.4 as it will be merged into #26587 to prevent a conflict there).
New commits:
8d05984 | Trac #26146 (py3): avoid comparison of NoneType and tuple
|
9e1bedb | Trac #26146 (py3): fix escape in re.sub
|
1b73a77 | Trac #26146 (py3): handle raised exceptions properly
|
2b124c5 | Trac #26146 (py3): fix Heisenbug due to non-sorting of subsets
|
comment:6 in reply to: ↑ 5 Changed 4 years ago by
comment:7 Changed 4 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, let it be. Thanks
comment:8 Changed 4 years ago by
- Branch changed from u/dkrenn/asy-py3 to 2b124c5e0ab80a4330fddd8adc028685bc51d073
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
as of 8.5.b1: