Opened 3 years ago

Closed 3 years ago

#26146 closed defect (fixed)

py3: doctests AsymptoticRing

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: behackl, cheuberg Merged in:
Authors: Daniel Krenn Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 2b124c5 (Commits, GitHub, GitLab) Commit: 2b124c5e0ab80a4330fddd8adc028685bc51d073
Dependencies: Stopgaps:

Status badges

Description (last modified by dkrenn)

There are many failing doctests in sage.rings.asymptotic when using Python3; fix them.

Many of them fail due to #26145 (which is part of the hashing issue of #24551).

Change History (8)

comment:1 Changed 3 years ago by dkrenn

  • Cc behackl cheuberg added

comment:2 Changed 3 years ago by dkrenn

  • Description modified (diff)

comment:3 Changed 3 years ago by chapoton

as of 8.5.b1: 

sage -t --long src/sage/rings/asymptotic/asymptotic_ring.py  # 6 doctests failed
sage -t --long src/sage/rings/asymptotic/growth_group.py  # 4 doctests failed
sage -t --long src/sage/rings/asymptotic/growth_group_cartesian.py  # 6 doctests failed
sage -t --long src/sage/rings/asymptotic/term_monoid.py  # 1 doctest failed

comment:4 Changed 3 years ago by dkrenn

  • Branch set to u/dkrenn/asy-py3

comment:5 follow-up: Changed 3 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to 2b124c5e0ab80a4330fddd8adc028685bc51d073
  • Status changed from new to needs_review

I've fixed the Python3-issues (tested with 8.5.beta2, but branch is based on 8.4 as it will be merged into #26587 to prevent a conflict there).

New commits:

​8d05984Trac #26146 (py3): avoid comparison of NoneType and tuple
​9e1bedbTrac #26146 (py3): fix escape in re.sub
​1b73a77Trac #26146 (py3): handle raised exceptions properly
​2b124c5Trac #26146 (py3): fix Heisenbug due to non-sorting of subsets

comment:6 in reply to: ↑ 5 Changed 3 years ago by dkrenn

Replying to dkrenn:

but branch is based on 8.4 as it will be merged into #26587 to prevent a conflict there

FYI, it seems that Git can merge this correctly, so no new dependency for #26587.

comment:7 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be. Thanks

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/dkrenn/asy-py3 to 2b124c5e0ab80a4330fddd8adc028685bc51d073
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.