#26144 closed defect (fixed)
principal_part_bound can be wrong when key has multiple slopes
Reported by:  Julian Rüth  Owned by:  

Priority:  major  Milestone:  sage8.6 
Component:  padics  Keywords:  
Cc:  Stefan Wewers  Merged in:  
Authors:  Julian Rüth  Reviewers:  Stefan Wewers 
Report Upstream:  N/A  Work issues:  
Branch:  e47eded (Commits, GitHub, GitLab)  Commit:  e47eded2f956455721b1eda66920e71483e1622d 
Dependencies:  Stopgaps: 
Description (last modified by )
Currently, the following fails:
sage: R.<x> = QQ[] sage: v_2 = QQ.valuation(2) sage: f = x^36 + 1160/81*x^31 + 9920/27*x^30 + 1040/81*x^26 + 52480/81*x^25 + 220160/81*x^24  5120/81*x^21  143360/81*x^20  573440/81*x^19 + 12451840/81*x^18  266240/567*x^16  20316160/567*x^15  198737920/189*x^14  1129840640/81*x^13  1907359744/27*x^12 + 8192/81*x^11 + 655360/81*x^10 + 5242880/21*x^9 + 2118123520/567*x^8 + 15460204544/567*x^7 + 6509559808/81*x^6  16777216/567*x^2  268435456/567*x  1073741824/567 sage: v_2.mac_lane_approximants(f) AssertionError
with the changes proposed by this ticket, this is
[[ Gauss valuation induced by 2adic valuation, v(x + 2056) = 23/2 ], [ Gauss valuation induced by 2adic valuation, v(x) = 11/9 ], [ Gauss valuation induced by 2adic valuation, v(x) = 2/5, v(x^5 + 4) = 7/2 ], [ Gauss valuation induced by 2adic valuation, v(x) = 3/5, v(x^10 + 8*x^5 + 64) = 7 ], [ Gauss valuation induced by 2adic valuation, v(x) = 3/5, v(x^5 + 8) = 5 ]]
Change History (15)
comment:1 Changed 4 years ago by
Branch:  → u/saraedum/26144 

comment:2 Changed 4 years ago by
Commit:  → e8b1d6208915ef9b04f5588b6489993a892b13e1 

Description:  modified (diff) 
comment:3 Changed 4 years ago by
Status:  new → needs_review 

Work issues:  → is the patchbot happy? 
comment:4 Changed 4 years ago by
Commit:  e8b1d6208915ef9b04f5588b6489993a892b13e1 → 7186bc6f298579f0c4e2c80db1ccd9b4917cfa63 

Branch pushed to git repo; I updated commit sha1. New commits:
7186bc6  Improve documentation of mac_lane_step()

comment:5 Changed 4 years ago by
Commit:  7186bc6f298579f0c4e2c80db1ccd9b4917cfa63 → 8bf114461e4ef5d0007da6f36526814a43798b4d 

Branch pushed to git repo; I updated commit sha1. New commits:
8bf1144  Comment on principal_part_bound correctness

comment:6 Changed 4 years ago by
Commit:  8bf114461e4ef5d0007da6f36526814a43798b4d → bde90844671f6fde28dc45253354bcb36618e0cd 

Branch pushed to git repo; I updated commit sha1. New commits:
bde9084  Clarify the meaning of principal_part_bound

comment:7 Changed 4 years ago by
Work issues:  is the patchbot happy? 

The patchbot errors are Magma errors and unrelated.
New commits:
bde9084  Clarify the meaning of principal_part_bound

comment:8 Changed 4 years ago by
Reviewers:  → Stefan Wewers 

Status:  needs_review → positive_review 
comment:10 Changed 4 years ago by
Commit:  bde90844671f6fde28dc45253354bcb36618e0cd → e47eded2f956455721b1eda66920e71483e1622d 

Branch pushed to git repo; I updated commit sha1. New commits:
e47eded  Merge remotetracking branch 'trac/develop' into 26144

comment:11 Changed 4 years ago by
Status:  needs_work → needs_review 

Work issues:  → is the patchbot happy ⇒ positive review 
comment:12 Changed 4 years ago by
Status:  needs_review → positive_review 

Work issues:  is the patchbot happy ⇒ positive review 
comment:13 Changed 4 years ago by
Milestone:  sage8.4 → sage8.5 

comment:14 Changed 4 years ago by
Branch:  u/saraedum/26144 → e47eded2f956455721b1eda66920e71483e1622d 

Resolution:  → fixed 
Status:  positive_review → closed 
comment:15 Changed 4 years ago by
Milestone:  sage8.5 → sage8.6 

This tickets were closed as fixed after the Sage 8.5 release.
Note: See
TracTickets for help on using
tickets.
New commits:
Properly handle repeated key polynomials