Opened 3 years ago

Closed 3 years ago

#26117 closed enhancement (fixed)

Upgrade to sympy 1.2

Reported by: saraedum Owned by:
Priority: major Milestone: sage-8.4
Component: packages: standard Keywords:
Cc: arojas, gh-timokau, fbissey, rws Merged in:
Authors: Julian Rüth Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: d94a0a3 (Commits, GitHub, GitLab) Commit: d94a0a3a3fb4aec05a6f4d95166d90c284f05c36
Dependencies: Stopgaps:

Status badges

Change History (22)

comment:1 Changed 3 years ago by saraedum

  • Description modified (diff)

comment:2 Changed 3 years ago by saraedum

  • Branch set to u/saraedum/26117

comment:3 Changed 3 years ago by git

  • Commit set to 8b90dde90a332e2d0ac4df59d3e6b9b0a86674a9

Branch pushed to git repo; I updated commit sha1. New commits:

8b90ddeThe arguments to a derivative can be variables or the variable and the order of the derivative

comment:4 Changed 3 years ago by git

  • Commit changed from 8b90dde90a332e2d0ac4df59d3e6b9b0a86674a9 to 4a24cd142f20ab6546fe586bd504865902cf30eb

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4a24cd1The arguments to a derivative can be variables or the variable and the order of the derivative

comment:5 Changed 3 years ago by git

  • Commit changed from 4a24cd142f20ab6546fe586bd504865902cf30eb to da274be17fcb48f8b147f326b78ef3310bbb2f44

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

da274beThe arguments to a derivative can be variables or the variable and the order of the derivative

comment:6 Changed 3 years ago by git

  • Commit changed from da274be17fcb48f8b147f326b78ef3310bbb2f44 to d94a0a3a3fb4aec05a6f4d95166d90c284f05c36

Branch pushed to git repo; I updated commit sha1. New commits:

d94a0a3Fix changed printing in sympy 1.12

comment:7 Changed 3 years ago by saraedum

  • Authors set to Julian Rüth
  • Status changed from new to needs_review

comment:8 Changed 3 years ago by saraedum

  • Cc arojas added

Arch Linux ships sympy 1.2 already. arojas, maybe you want to review here?

comment:9 Changed 3 years ago by saraedum

Long tests pass btw.

comment:10 Changed 3 years ago by gh-timokau

  • Cc gh-timokau added

comment:11 Changed 3 years ago by fbissey

  • Cc fbissey added

comment:12 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

LGTM

comment:13 Changed 3 years ago by gh-timokau

  • Cc rws added

Why isn't 03_undeffun_sage.patch upstreamed? Is there an upstream PR for that?

comment:15 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work
Installing collected packages: sympy
  Created temporary directory: /tmp/pip-record-mtnz9f
  Running setup.py install for sympy: started
    Running command /mnt/disk/home/release/Sage/local/bin/python2 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-6ysf3v/set
up.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" --no
-user-cfg install --record /tmp/pip-record-mtnz9f/install-record.txt --single-version-externally-managed --root /mnt/disk/home/release/Sage/
local/var/tmp/sage/build/sympy-1.2.p0/inst --compile
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-6ysf3v/setup.py", line 424, in <module>
        **extra_kwargs
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/setuptools/__init__.py", line 130, in setup
        _install_setup_requires(attrs)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/setuptools/__init__.py", line 119, in _install_setup_requires
        (k, v) for k, v in attrs.items()
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/setuptools/dist.py", line 367, in __init__
        for ep in pkg_resources.iter_entry_points('distutils.setup_keywords'):
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 644, in iter_entry_points
        entries = dist.get_entry_map(group)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2711, in get_entry_map
        self._get_metadata('entry_points.txt'), self
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2405, in parse_map
        for group, lines in data:
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3046, in split_sections
        for line in yield_lines(s):
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2265, in yield_lines
        for ss in strs:
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2624, in _get_metadata
        for line in self.get_metadata_lines(name):
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1407, in get_metadata_lines
        return yield_lines(self.get_metadata(name))
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1403, in get_metadata
        value = self._get(self._fn(self.egg_info, name))
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1515, in _get
        with open(path, 'rb') as stream:
    IOError: [Errno 2] No such file or directory: '/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/jupyter_client-5.2.2-py2.7.egg-info/entry_points.txt'
    Running setup.py install for sympy: finished with status 'error'
Cleaning up...
  Removing source in /tmp/pip-req-build-6ysf3v
Removed build tracker '/tmp/pip-req-tracker-LdRUsc'
Command "/mnt/disk/home/release/Sage/local/bin/python2 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-6ysf3v/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" --no-user-cfg install --record /tmp/pip-record-mtnz9f/install-record.txt --single-version-externally-managed --root /mnt/disk/home/release/Sage/local/var/tmp/sage/build/sympy-1.2.p0/inst --compile" failed with error code 1 in /tmp/pip-req-build-6ysf3v/
Exception information:
Traceback (most recent call last):
  File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pip/_internal/basecommand.py", line 141, in main
    status = self.run(options, args)
  File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pip/_internal/commands/install.py", line 347, in run
    use_user_site=options.use_user_site,
  File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pip/_internal/req/__init__.py", line 49, in install_given_reqs
    **kwargs
  File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pip/_internal/req/req_install.py", line 972, in install
    spinner=spinner,
  File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/pip/_internal/utils/misc.py", line 701, in call_subprocess
    % (command_desc, proc.returncode, cwd))
InstallationError: Command "/mnt/disk/home/release/Sage/local/bin/python2 -u -c "import setuptools, tokenize;__file__='/tmp/pip-req-build-6ysf3v/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" --no-user-cfg install --record /tmp/pip-record-mtnz9f/install-record.txt --single-version-externally-managed --root /mnt/disk/home/release/Sage/local/var/tmp/sage/build/sympy-1.2.p0/inst --compile" failed with error code 1 in /tmp/pip-req-build-6ysf3v/
Error: installing with pip2 failed

comment:16 Changed 3 years ago by dimpase

what OS is this error on?

comment:17 Changed 3 years ago by jdemeyer

  • Status changed from needs_work to positive_review

vbraun: isn't that just an instance of #26018?

Last edited 3 years ago by jdemeyer (previous) (diff)

comment:18 Changed 3 years ago by vbraun

  • Dependencies set to 26018

comment:19 Changed 3 years ago by saraedum

  • Dependencies changed from 26018 to #26018

comment:20 Changed 3 years ago by vbraun

  • Dependencies #26018 deleted

comment:21 Changed 3 years ago by dimpase

and meanwhile 1.3 has been released.

comment:22 Changed 3 years ago by vbraun

  • Branch changed from u/saraedum/26117 to d94a0a3a3fb4aec05a6f4d95166d90c284f05c36
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.