Opened 4 years ago

Closed 4 years ago

#26102 closed enhancement (fixed)

Speed up search_doc

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-8.4
Component: misc Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: e837e5b (Commits, GitHub, GitLab) Commit: e837e5b66af8b3dc764d0573e5fb79ad65b18d1a
Dependencies: Stopgaps:

Status badges

Description

The function search_doc in sage/misc/sagedoc.py could be sped up: only search the html directory of local/share/doc/sage, and skip the _static subdirectories.

Change History (6)

comment:1 Changed 4 years ago by jhpalmieri

  • Component changed from PLEASE CHANGE to misc
  • Priority changed from major to minor
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 4 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/speed_up_search_doc

comment:3 Changed 4 years ago by jhpalmieri

  • Commit set to e837e5b66af8b3dc764d0573e5fb79ad65b18d1a
  • Status changed from new to needs_review

New commits:

​e837e5btrac 26102: speed up search_doc

comment:4 Changed 4 years ago by jhpalmieri

Some tests results on one computer (these obviously depend on the speed of the hard drive, among other things):

  • with 8.4.beta1 (devel): %time search_doc('curl') takes about 65 seconds.
  • with this branch: %time search_doc('curl') takes about 6 seconds.

comment:5 Changed 4 years ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

Huge improvement!

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jhpalmieri/speed_up_search_doc to e837e5b66af8b3dc764d0573e5fb79ad65b18d1a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.