Opened 4 years ago

Closed 4 years ago

#26082 closed enhancement (fixed)

py3: let pip use the correct python

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: embray, jdemeyer, fbissey Merged in:
Authors: Frédéric Chapoton Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 0827d87 (Commits, GitHub, GitLab) Commit: 0827d8762ef057b142e66decb39c78d52cae8324
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

because being able to do sage -pip install stuff is crucial in the python3 build of sage.

Change History (9)

comment:1 Changed 4 years ago by chapoton

  • Branch set to public/26082
  • Commit set to 1e46d20ddb11892d8264660d78e6dc93a51d39da
  • Status changed from new to needs_review

New commits:

1e46d20adding --pip3 to command line

comment:2 Changed 4 years ago by chapoton

oh, dman ! I had tried that before in #20911

Version 0, edited 4 years ago by chapoton (next)

comment:3 Changed 4 years ago by embray

  • Milestone changed from sage-8.4 to sage-duplicate/invalid/wontfix

Right now we include both pythons for some reason, but ultimately we only want there to be one, and certainly only one that the sage command line cares about.

comment:4 Changed 4 years ago by embray

What you might do instead (you can reuse this ticket) is to change sage -pip to invoke sage-python23 -m pip.

comment:5 Changed 4 years ago by git

  • Commit changed from 1e46d20ddb11892d8264660d78e6dc93a51d39da to 0827d8762ef057b142e66decb39c78d52cae8324

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0827d87trac 26082 switching pip using sage-python23

comment:6 Changed 4 years ago by chapoton

  • Milestone changed from sage-duplicate/invalid/wontfix to sage-8.4

ok, good idea. Done

comment:7 Changed 4 years ago by chapoton

  • Description modified (diff)
  • Summary changed from py3: adding pip3 to command line options to py3: let pip use the correct python

comment:8 Changed 4 years ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

Sounds good.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from public/26082 to 0827d8762ef057b142e66decb39c78d52cae8324
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.